Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935086AbZJOJcs (ORCPT ); Thu, 15 Oct 2009 05:32:48 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S934663AbZJOJcr (ORCPT ); Thu, 15 Oct 2009 05:32:47 -0400 Received: from mx2.mail.elte.hu ([157.181.151.9]:50921 "EHLO mx2.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934191AbZJOJcq (ORCPT ); Thu, 15 Oct 2009 05:32:46 -0400 Date: Thu, 15 Oct 2009 11:31:33 +0200 From: Ingo Molnar To: Simon Kagstrom Cc: Linus Torvalds , linux-mtd , Artem Bityutskiy , David Woodhouse , Andrew Morton , LKML , "Koskinen Aaro (Nokia-D/Helsinki)" , Alan Cox Subject: Re: [PATCH v7 4/5]: core: Add kernel message dumper to call on oopses and panics Message-ID: <20091015093133.GF10546@elte.hu> References: <20091015094057.7298e0d7@marrow.netinsight.se> <20091015094805.754461fa@marrow.netinsight.se> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20091015094805.754461fa@marrow.netinsight.se> User-Agent: Mutt/1.5.18 (2008-05-17) X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.5 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1089 Lines: 44 * Simon Kagstrom wrote: > --- /dev/null > +++ b/include/linux/kmsg_dump.h > +enum kmsg_dump_reason { > + kmsg_dump_oops, > + kmsg_dump_panic, > +}; Please capitalize constants - lower case suggests it's some sort of variable which it is not. > +void dump_kmsg(enum kmsg_dump_reason reason); > + > +int register_kmsg_dumper(struct kmsg_dumper *dumper); > + > +void unregister_kmsg_dumper(struct kmsg_dumper *dumper); Please rename these APIs to be more in line with how we name new kernel APIs. Something like: kmsg_dump() kmsg_dumper_register() kmsg_dumper_unregister() (we start with the subsystem as a prefix, then we go from more generic to less generic words.) Might even make sense to name them all kmsg_dump: kmsg_dump() kmsg_dump_register() kmsg_dump_unregister() Thanks, Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/