Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762860AbZJOQFP (ORCPT ); Thu, 15 Oct 2009 12:05:15 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1762228AbZJOQFO (ORCPT ); Thu, 15 Oct 2009 12:05:14 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:59664 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757636AbZJOQFN (ORCPT ); Thu, 15 Oct 2009 12:05:13 -0400 Date: Thu, 15 Oct 2009 09:04:09 -0700 (PDT) From: Linus Torvalds X-X-Sender: torvalds@localhost.localdomain To: Oleg Nesterov cc: Alan Cox , Paul Fulghum , Boyan , "Rafael J. Wysocki" , Linux Kernel Mailing List , Kernel Testers List , Dmitry Torokhov , Ed Tomlinson , OGAWA Hirofumi Subject: Re: [Bug #14388] keyboard under X with 2.6.31 In-Reply-To: <20091015152959.GA18681@redhat.com> Message-ID: References: <4AD51D6B.7010509@microgate.com> <20091014125846.1a3c8d40@lxorguk.ukuu.org.uk> <20091014182037.GA10076@redhat.com> <20091014195215.GA12936@redhat.com> <20091015124730.GA9398@redhat.com> <20091015152959.GA18681@redhat.com> User-Agent: Alpine 2.01 (LFD 1184 2008-12-16) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 964 Lines: 25 On Thu, 15 Oct 2009, Oleg Nesterov wrote: > > Actually, this looks simple. Please see the patch below. Ok, I should have read all my emails before responding to the previous one. But my response ends up being the same: I think your patch is fine, and I think you should drop the conditional flag. I don't think anybody _ever_ wants to run the same work entry on multiple CPU's at once. Anybody who wants parallelism needs to use multiple work entries _anyway_ (since the accidental parallelism you *can* get with a single one is really very accidental indeed). Of course, it should be tested in -next for a while regardless. And talk to the networkng people, who are the main user of workqueues. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/