Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1763104AbZJOWa2 (ORCPT ); Thu, 15 Oct 2009 18:30:28 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1763079AbZJOWa1 (ORCPT ); Thu, 15 Oct 2009 18:30:27 -0400 Received: from mail.parknet.ad.jp ([210.171.162.6]:52177 "EHLO mail.officemail.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1763027AbZJOWaY (ORCPT ); Thu, 15 Oct 2009 18:30:24 -0400 From: OGAWA Hirofumi To: Linus Torvalds Cc: Alan Cox , Oleg Nesterov , Paul Fulghum , Boyan , "Rafael J. Wysocki" , Linux Kernel Mailing List , Kernel Testers List , Dmitry Torokhov , Ed Tomlinson Subject: Re: [Bug #14388] keyboard under X with 2.6.31 References: <56acieJJ2fF.A.nEB.Hzl0KB@chimera> <87ljjgfcbu.fsf@spindle.srvr.nix> <4AD3F769.5080405@gmail.com> <4AD437F9.9020708@yahoo.co.uk> <4AD4DE4C.4010402@yahoo.co.uk> <4AD4F548.2030506@microgate.com> <1255478932.19056.24.camel@localhost.localdomain> <4AD51D6B.7010509@microgate.com> <20091014125846.1a3c8d40@lxorguk.ukuu.org.uk> <87aazsh80x.fsf@devron.myhome.or.jp> Date: Fri, 16 Oct 2009 07:29:41 +0900 In-Reply-To: (Linus Torvalds's message of "Thu, 15 Oct 2009 14:49:56 -0700 (PDT)") Message-ID: <87ljjce1ey.fsf@devron.myhome.or.jp> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1207 Lines: 44 Linus Torvalds writes: > On Fri, 16 Oct 2009, OGAWA Hirofumi wrote: >> >> I.e. the following or something, >> >> static inline int input_available_p(struct tty_struct *tty, int amt) >> { >> int try = 0; >> >> retry: >> if (tty->icanon) { >> if (tty->canon_data) >> return 1; >> } else if (tty->read_cnt >= (amt ? amt : 1)) >> return 1; >> >> if (!checked) { >> tty_flush_to_ldisc(tty); >> try = 1; >> goto retry; >> } >> >> return 0; >> } > > Yeah, we could do that. Especially if we ever see this in any profiles. I > doubt we do, but.. Yes. Or, FWIW, I was thinking to delete schedule_delayed_work() for n_tty with flag or something at previous time. I.e. disable background flush_to_ldisc() by writer for n_tty, only n_tty_read() will check tty.buf synchronously. So, with it, unnecessary flush_to_ldisc() is removed completely... Well... Thanks. -- OGAWA Hirofumi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/