Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1763079AbZJOWiF (ORCPT ); Thu, 15 Oct 2009 18:38:05 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756675AbZJOWiE (ORCPT ); Thu, 15 Oct 2009 18:38:04 -0400 Received: from smtp-outbound-2.vmware.com ([65.115.85.73]:44888 "EHLO smtp-outbound-2.vmware.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754451AbZJOWiB convert rfc822-to-8bit (ORCPT ); Thu, 15 Oct 2009 18:38:01 -0400 From: Shreyas Bhatewara To: Randy Dunlap , Stephen Rothwell CC: "linux-next@vger.kernel.org" , LKML , netdev , David Miller , "pv-drivers@vmware.com" Date: Thu, 15 Oct 2009 15:37:23 -0700 Subject: RE: [PATCH -next] vmxnet3: use dev_dbg, fix build for CONFIG_BLOCK=n Thread-Topic: [PATCH -next] vmxnet3: use dev_dbg, fix build for CONFIG_BLOCK=n Thread-Index: AcpN5xXSL9nm1bevRVCWduIodoZw0AAANDfg Message-ID: <89E2752CFA8EC044846EB8499819134101741BA4C0@EXCH-MBX-4.vmware.com> References: <20091015152538.74a1cb15.sfr@canb.auug.org.au> <4AD7A24F.6000900@oracle.com> In-Reply-To: <4AD7A24F.6000900@oracle.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1535 Lines: 41 > -----Original Message----- > From: Randy Dunlap [mailto:randy.dunlap@oracle.com] > Sent: Thursday, October 15, 2009 3:30 PM > To: Stephen Rothwell > Cc: linux-next@vger.kernel.org; LKML; netdev; David Miller; Shreyas > Bhatewara; pv-drivers@vmware.com > Subject: [PATCH -next] vmxnet3: use dev_dbg, fix build for > CONFIG_BLOCK=n > > From: Randy Dunlap > > vmxnet3 was using dprintk() for debugging output. This was > defined in and was the only thing that was > used from that header file. This caused compile errors > when CONFIG_BLOCK was not enabled due to bio* and BIO* > uses in the header file, so change this driver to use > dev_dbg() for debugging output. > > include/linux/dst.h:520: error: dereferencing pointer to incomplete > type > include/linux/dst.h:520: error: 'BIO_POOL_BITS' undeclared (first use > in this function) > include/linux/dst.h:521: error: dereferencing pointer to incomplete > type > include/linux/dst.h:522: error: dereferencing pointer to incomplete > type > include/linux/dst.h:525: error: dereferencing pointer to incomplete > type > make[4]: *** [drivers/net/vmxnet3/vmxnet3_drv.o] Error 1 > > Signed-off-by: Randy Dunlap Thanks for the changes Randy, appreciate it. ->Shreyas -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/