Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1763283AbZJOWyN (ORCPT ); Thu, 15 Oct 2009 18:54:13 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1763219AbZJOWyM (ORCPT ); Thu, 15 Oct 2009 18:54:12 -0400 Received: from smtp-outbound-1.vmware.com ([65.115.85.69]:59785 "EHLO smtp-outbound-1.vmware.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1763259AbZJOWyK convert rfc822-to-8bit (ORCPT ); Thu, 15 Oct 2009 18:54:10 -0400 From: Bhavesh Davda To: Dmitry Torokhov , "pv-drivers@vmware.com" CC: Randy Dunlap , Stephen Rothwell , netdev , LKML , "linux-next@vger.kernel.org" , David Miller Date: Thu, 15 Oct 2009 15:53:33 -0700 Subject: RE: [Pv-drivers] [PATCH -next] vmxnet3: use dev_dbg, fix build for CONFIG_BLOCK=n Thread-Topic: [Pv-drivers] [PATCH -next] vmxnet3: use dev_dbg, fix build for CONFIG_BLOCK=n Thread-Index: AcpN6YVrtoiUrtGbQrO+/REYRZcYogAAHQ5Q Message-ID: <8B1F619C9F5F454E81D90D3C161698D7017DD5644B@EXCH-MBX-3.vmware.com> References: <20091015152538.74a1cb15.sfr@canb.auug.org.au> <8B1F619C9F5F454E81D90D3C161698D7017DD56435@EXCH-MBX-3.vmware.com> <4AD7A569.1040308@oracle.com> <200910151547.48247.dtor@vmware.com> In-Reply-To: <200910151547.48247.dtor@vmware.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: en-US Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1275 Lines: 44 > From: Dmitry Torokhov [mailto:dtor@vmware.com] > Sent: Thursday, October 15, 2009 3:48 PM > To: pv-drivers@vmware.com > Cc: Randy Dunlap; Bhavesh Davda; Stephen Rothwell; netdev; LKML; linux- > next@vger.kernel.org; David Miller > Subject: Re: [Pv-drivers] [PATCH -next] vmxnet3: use dev_dbg, fix build > for CONFIG_BLOCK=n > > Hi Randy, > > On Thursday 15 October 2009 03:42:49 pm Randy Dunlap wrote: > > Bhavesh Davda wrote: > > > Who ever compiles with CONFIG_BLOCK=n? Just kidding... > > > > or why does networking need CONFIG_BLOCK at all? ;) > > > > > Thanks again for making this change! Ship it! > > > > So could I have used adapter->netdev->dev or adapter->pdev->dev ? > > either of them? are they the same? > > > > They are the same. Right: vmxnet3_probe_device(struct pci_dev *pdev,...) struct net_device *netdev; ... netdev = alloc_etherdev(sizeof(struct vmxnet3_adapter)); ... pci_set_drvdata(pdev, netdev); adapter = netdev_priv(netdev); adapter->netdev = netdev; adapter->pdev = pdev; - Bhavesh -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/