Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752043AbZJPJ3S (ORCPT ); Fri, 16 Oct 2009 05:29:18 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751327AbZJPJ3R (ORCPT ); Fri, 16 Oct 2009 05:29:17 -0400 Received: from ns.penguin.cz ([84.21.108.25]:33453 "EHLO ns.penguin.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751125AbZJPJ3Q (ORCPT ); Fri, 16 Oct 2009 05:29:16 -0400 Subject: Re: spitz: add gpio button support (fixes regression) From: Stanislav Brabec To: Pavel Machek Cc: Eric Miao , Andrew Morton , Mark Brown , rpurdie@rpsys.net, lenz@cs.wisc.edu, kernel list , Dirk@opfer-online.de, arminlitzel@web.de, Cyril Hrubis , thommycheck@gmail.com, linux-arm-kernel , dbaryshkov@gmail.com, omegamoon@gmail.com In-Reply-To: <20091015215215.GG15898@elf.ucw.cz> References: <20091006074635.GA2775@ucw.cz> <1254829732.3546.35.camel@utx.utx.cz> <20091007085806.GB28807@elf.ucw.cz> <1254914991.4213.80.camel@hammer.suse.cz> <20091007120643.GA17069@rakim.wolfsonmicro.main> <20091006200933.GA1606@ucw.cz> <1255641385.3985.55.camel@utx.utx.cz> <20091015212024.GC15898@elf.ucw.cz> <1255643252.3985.63.camel@utx.utx.cz> <20091015215215.GG15898@elf.ucw.cz> Content-Type: text/plain; charset="ISO-8859-2" Date: Fri, 16 Oct 2009 11:28:35 +0200 Message-Id: <1255685315.5470.3.camel@hammer.suse.cz> Mime-Version: 1.0 X-Mailer: Evolution 2.28.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1564 Lines: 44 Pavel Machek wrote: > On Thu 2009-10-15 23:47:32, Stanislav Brabec wrote: > > Pavel Machek wrote: > > >Well, resume is hit by second regression. > > > > > >Suspend key.... I restored it to the level of functionality in > > >2.6.31 :-). > > > > > > + .type = EV_KEY, > > > > + .code = KEY_SUSPEND, > > > > I guess it should be EV_PWR. Then it will at least go to suspend. > > Does it actually go to suspend with that change? Yes. > (Actually, I wonder how it could have ever worked: userspace should > certainly be in a loop there; kernel should not suspend machine on its > own. In -rp kernels, kernel _does_ suspend on its own, but... I'm not > sure if that's suitable for mainline). At least userspace apmd should be able to enter into suspend process (tested in 2.6.26-RP, not yet verified in 2.6.32-rc*). I don't know, what is the preferred way in recent days, but Tosa does the same. -- Best Regards / S pozdravem, Stanislav Brabec software developer --------------------------------------------------------------------- SUSE LINUX, s. r. o. e-mail: sbrabec@suse.cz Lihovarsk? 1060/12 tel: +420 284 028 966, +49 911 740538747 190 00 Praha 9 fax: +420 284 028 951 Czech Republic http://www.suse.cz/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/