Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759273AbZJPPQy (ORCPT ); Fri, 16 Oct 2009 11:16:54 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755546AbZJPPQw (ORCPT ); Fri, 16 Oct 2009 11:16:52 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42974 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752615AbZJPPQv (ORCPT ); Fri, 16 Oct 2009 11:16:51 -0400 Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <7e0fb38c0910160801o50346a5cm763d79cab98272a5@mail.gmail.com> References: <7e0fb38c0910160801o50346a5cm763d79cab98272a5@mail.gmail.com> <1255516134-4838-1-git-send-email-graff.yang@gmail.com> <18475.1255529305@redhat.com> To: Eric Paris Cc: dhowells@redhat.com, graff.yang@gmail.com, linux-kernel@vger.kernel.org, gyang@blackfin.uclinux.org, akpm@linux-foundation.org, uclinux-dist-devel@blackfin.uclinux.org, Graff Yang , linux-security-module@vger.kernel.org Subject: Re: [PATCH] mm/nommu.c: Fix improperly call of security API in mmap Date: Fri, 16 Oct 2009 16:14:50 +0100 Message-ID: <6207.1255706090@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1008 Lines: 21 Eric Paris wrote: > I really don't like seeing such irrelevant (that's not the right word, > but I can't think what is) ifdefs creeping down into the security > layer as LSM authors are likely to mess them up in the future. I'd > probably rather see the addr_only argument changed into a flags field. > One for addr_only and one flag for not_addr. The nommu case could > just set the not_addr flag and it's obvious how the LSMs (or > capabilities if !CONFIG_SECURITY) should handle it, also works if some > other future need arises... A better way still, might be to deny the possibility of CONFIG_SECURITY if CONFIG_MMU=n. After all, security is sort of pointless when a userspace program can just edit the kernel at a whim. David -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/