Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932358AbZJPTHP (ORCPT ); Fri, 16 Oct 2009 15:07:15 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932128AbZJPTHO (ORCPT ); Fri, 16 Oct 2009 15:07:14 -0400 Received: from smtp-out.google.com ([216.239.45.13]:28070 "EHLO smtp-out.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932096AbZJPTHN (ORCPT ); Fri, 16 Oct 2009 15:07:13 -0400 DomainKey-Signature: a=rsa-sha1; s=beta; d=google.com; c=nofws; q=dns; h=date:from:x-x-sender:to:cc:subject:in-reply-to:message-id: references:user-agent:mime-version:content-type:x-system-of-record; b=Z/eEyW1TNsgPiURWZfKujvCYm2V4pjO+Qe5jC0EooMawjafwhMXezl+eU4i0Sc5n8 zQMfwAKE9vE1iIXx1Rr2w== Date: Fri, 16 Oct 2009 12:07:07 -0700 (PDT) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: Mel Gorman cc: Andrew Morton , stable , "Rafael J. Wysocki" , David Miller , Frans Pop , reinette chatre , Kalle Valo , "John W. Linville" , Pekka Enberg , Bartlomiej Zolnierkiewicz , Karol Lewandowski , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, "linux-mm@kvack.org\"" Subject: Re: [PATCH 2/2] page allocator: Direct reclaim should always obey watermarks In-Reply-To: <1255689446-3858-3-git-send-email-mel@csn.ul.ie> Message-ID: References: <1255689446-3858-1-git-send-email-mel@csn.ul.ie> <1255689446-3858-3-git-send-email-mel@csn.ul.ie> User-Agent: Alpine 1.00 (DEB 882 2007-12-20) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-System-Of-Record: true Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1456 Lines: 36 On Fri, 16 Oct 2009, Mel Gorman wrote: > ALLOC_NO_WATERMARKS should be cleared when trying to allocate from the > free-lists after a direct reclaim. If it's not, __GFP_NOFAIL allocations > from a process that is exiting can ignore watermarks. __GFP_NOFAIL is not > often used but the journal layer is one of those places. This is suspected of > causing an increase in the number of GFP_ATOMIC allocation failures reported. > > Signed-off-by: Mel Gorman > --- > mm/page_alloc.c | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index dfa4362..a3e5fed 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -1860,7 +1860,8 @@ rebalance: > page = __alloc_pages_direct_reclaim(gfp_mask, order, > zonelist, high_zoneidx, > nodemask, > - alloc_flags, preferred_zone, > + alloc_flags & ~ALLOC_NO_WATERMARKS, > + preferred_zone, > migratetype, &did_some_progress); > if (page) > goto got_pg; I don't get it. __alloc_pages_high_priority() will already loop indefinitely if ALLOC_NO_WATERMARKS is set and its a __GFP_NOFAIL allocation. How do we even reach this code in such a condition? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/