Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752796AbZJQA7D (ORCPT ); Fri, 16 Oct 2009 20:59:03 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752359AbZJQA7C (ORCPT ); Fri, 16 Oct 2009 20:59:02 -0400 Received: from exprod6og112.obsmtp.com ([64.18.1.29]:48999 "HELO exprod6og112.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1750838AbZJQA7B convert rfc822-to-8bit (ORCPT ); Fri, 16 Oct 2009 20:59:01 -0400 X-MimeOLE: Produced By Microsoft Exchange V6.5 Content-class: urn:content-classes:message MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT Subject: [PATCH] block/scsi_ioctl.c: quiet sparse noise Date: Fri, 16 Oct 2009 20:59:04 -0400 Message-ID: X-MS-Has-Attach: X-MS-TNEF-Correlator: Thread-Topic: [PATCH] block/scsi_ioctl.c: quiet sparse noise Thread-Index: AcpOxQX9wa/ZzU1qTUuqhmX9c3bHeA== From: "H Hartley Sweeten" To: X-OriginalArrivalTime: 17 Oct 2009 00:59:04.0960 (UTC) FILETIME=[05FEF800:01CA4EC5] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1289 Lines: 40 Quiet sparse noise about symbol's not being declared. Symbol blk_default_cmd_filter is only used locally and should be static. The function blk_scsi_ioctl_init() is a fs_initcall and should also be static. Signed-off-by: H Hartley Sweeten --- diff --git a/block/scsi_ioctl.c b/block/scsi_ioctl.c index e5b1001..a8b5a10 100644 --- a/block/scsi_ioctl.c +++ b/block/scsi_ioctl.c @@ -35,7 +35,9 @@ struct blk_cmd_filter { unsigned long read_ok[BLK_SCSI_CMD_PER_LONG]; unsigned long write_ok[BLK_SCSI_CMD_PER_LONG]; -} blk_default_cmd_filter; +}; + +static struct blk_cmd_filter blk_default_cmd_filter; /* Command group 3 is reserved and should never be used. */ const unsigned char scsi_command_size_tbl[8] = @@ -675,7 +677,7 @@ int scsi_cmd_ioctl(struct request_queue *q, struct gendisk *bd_disk, fmode_t mod } EXPORT_SYMBOL(scsi_cmd_ioctl); -int __init blk_scsi_ioctl_init(void) +static int __init blk_scsi_ioctl_init(void) { blk_set_cmd_filter_defaults(&blk_default_cmd_filter); return 0; -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/