Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752878AbZJQBDr (ORCPT ); Fri, 16 Oct 2009 21:03:47 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752572AbZJQBDr (ORCPT ); Fri, 16 Oct 2009 21:03:47 -0400 Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:43306 "EHLO sunset.davemloft.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752359AbZJQBDr (ORCPT ); Fri, 16 Oct 2009 21:03:47 -0400 Date: Fri, 16 Oct 2009 18:04:09 -0700 (PDT) Message-Id: <20091016.180409.204538933.davem@davemloft.net> To: hartleys@visionengravers.com Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] net/ipv4/ipconfig.c: local symbols should be static From: David Miller In-Reply-To: References: X-Mailer: Mew version 6.2.51 on Emacs 22.1 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 761 Lines: 20 From: "H Hartley Sweeten" Date: Fri, 16 Oct 2009 19:30:02 -0400 > The symbol ic_dev_xid is only used locally to track the device being > configured. As such, it should be static. > > Signed-off-by: H Hartley Sweeten 1) Your patch doesn't apply to current sources. 2) You need to CC: all networking patch submissions to netdev@vger.kernel.org so that your patch gets properly tracked at http://patchwork.ozlabs.org/project/netdev/list Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/