Date: Sat, 17 Oct 2009 16:41:59 -0400 (EDT)
From: Christoph Lameter <cl@linux-foundation.org>
To: David Rientjes <rientjes@google.com>
cc: Pekka Enberg <penberg@cs.helsinki.fi>, linux-kernel@vger.kernel.org
Subject: Re: [patch] slub: allow stats to be cleared
In-Reply-To: <alpine.DEB.1.00.0910170154580.31277@chino.kir.corp.google.com>
Message-ID: <alpine.DEB.1.10.0910171637180.28063@gentwo.org>
References: <alpine.DEB.1.00.0910150215320.1551@chino.kir.corp.google.com> <alpine.DEB.1.10.0910161249100.6120@gentwo.org> <alpine.DEB.1.00.0910161129320.21328@chino.kir.corp.google.com> <alpine.DEB.1.10.0910162126090.26081@gentwo.org>
 <alpine.DEB.1.00.0910170154580.31277@chino.kir.corp.google.com>
User-Agent: Alpine 1.10 (DEB 962 2008-03-14)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1107
Lines: 27

On Sat, 17 Oct 2009, David Rientjes wrote:

> On Fri, 16 Oct 2009, Christoph Lameter wrote:
>
> > > No, it just clears that particular statistic.
> >
> > Ahh. Yes I mis-scanned the loop there. Would it not be better to reset all
> > counters using some trigger file? Its a bit difficult to reset them all
> > with this patch.
> >
>
> Pekka seems willing to look at a patch that moves all statistic files to
> /sys/kernel/slab/cache/stats, so it should make both collecting and now
> clearing stats very easy without the addition of another file.

I think we should move the stats regardless of that issue.

I'd also like to be able to just do a single echo
to clear the all stats instead of everyone trying to improvise something
to touch all files. Its highly unlikely that one only wants to zero
individual counters.  One way to reset them all would suffice.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/