Subject: Re: nfs mount fail
From: Trond Myklebust <trond.myklebust@fys.uio.no>
To: Ingo Molnar <mingo@elte.hu>
Cc: Yinghai Lu <yhlu.kernel@gmail.com>, Pekka Enberg <penberg@cs.helsinki.fi>,
       Arjan van de Ven <arjan@infradead.org>,
       David Miller <davem@davemloft.net>,
       Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
In-Reply-To: <20091019082333.GA27410@elte.hu>
References: <20091019114339.4b67d947@infradead.org>
	 <1255921080.839.2.camel@penberg-laptop>
	 <86802c440910182252v4648a7d1k249d091799583e37@mail.gmail.com>
	 <1255933848.11116.2.camel@heimdal.trondhjem.org>
	 <20091019065433.GA29550@elte.hu> <1255935518.18914.0.camel@penberg-laptop>
	 <20091019070825.GA16493@elte.hu>
	 <86802c440910190031m33e116d3o90869de5212bb2e@mail.gmail.com>
	 <1255938774.11116.35.camel@heimdal.trondhjem.org>
	 <20091019080403.GA24036@elte.hu>  <20091019082333.GA27410@elte.hu>
Content-Type: text/plain
Date: Mon, 19 Oct 2009 17:29:11 +0900
Message-Id: <1255940951.14447.9.camel@heimdal.trondhjem.org>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1609
Lines: 45

On Mon, 2009-10-19 at 10:23 +0200, Ingo Molnar wrote:
> * Ingo Molnar <mingo@elte.hu> wrote:
> 
> > 
> > * Trond Myklebust <trond.myklebust@fys.uio.no> wrote:
> > 
> > > > --- a/fs/nfs/super.c
> > > > +++ b/fs/nfs/super.c
> > > > @@ -1253,6 +1253,7 @@ static int nfs_parse_mount_options(char *raw,
> > > >  			default:
> > > >  				dfprintk(MOUNT, "NFS:   unrecognized "
> > > >  						"transport protocol\n");
> > > > +				kfree(string);
> > > >  				return 0;
> > > >  			}
> > > >  			break;
> > > 
> > > There is a possible clean up there too. We can move the other kfree() 
> > > calls out of the inner switch statement, and coalesce them all into a 
> > > single call.
> > 
> > Correct - separately from the leak fix. (which potentially wants to go 
> > to -stable as well)
> 
> Not necessarily -stable material though - this is a really light memory 
> leak and only on a rare failure path, i doubt anyone noticed in 
> practice.
> 
> So d508afb fixed all that needed fixing and there's nothing serious 
> pending here. I've reverted all pending bits in tip:out-of-tree, so it's 
> pure -git now. I rarely have to carry any NFS fixes in out-of-tree, this 
> was an odd-one-out exception that fell through the cracks.
> 
> 	Ingo

OK. Could you resend the remaining leak fix, with the fixed up changelog
and attributions so I can pass it on to Linus?

Trond

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/