Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756118AbZJSMwf (ORCPT ); Mon, 19 Oct 2009 08:52:35 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756009AbZJSMwe (ORCPT ); Mon, 19 Oct 2009 08:52:34 -0400 Received: from mx3.mail.elte.hu ([157.181.1.138]:38607 "EHLO mx3.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755948AbZJSMwe (ORCPT ); Mon, 19 Oct 2009 08:52:34 -0400 Date: Mon, 19 Oct 2009 14:50:17 +0200 From: Ingo Molnar To: Artem Bityutskiy Cc: Simon Kagstrom , linux-mtd , Linus Torvalds , David Woodhouse , Andrew Morton , LKML , "Koskinen Aaro (Nokia-D/Helsinki)" , Alan Cox Subject: Re: [PATCH v11 4/5] core: Add kernel message dumper to call on oopses and panics Message-ID: <20091019125017.GA9030@elte.hu> References: <20091015093133.GF10546@elte.hu> <20091015161052.0752208e@marrow.netinsight.se> <20091015154640.GA11408@elte.hu> <20091016094601.4e2c2d3e@marrow.netinsight.se> <20091016080935.GA3895@elte.hu> <1255681467.32489.360.camel@localhost> <20091016112556.6902b2dc@marrow.netinsight.se> <20091016101045.GA3263@elte.hu> <20091016140918.3981cfa2@marrow.netinsight.se> <1255952922.32489.505.camel@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1255952922.32489.505.camel@localhost> User-Agent: Mutt/1.5.19 (2009-01-05) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1777 Lines: 45 * Artem Bityutskiy wrote: > On Fri, 2009-10-16 at 14:09 +0200, Simon Kagstrom wrote: > > The core functionality is implemented as per Linus suggestion from > > > > http://lists.infradead.org/pipermail/linux-mtd/2009-October/027620.html > > > > (with the kmsg_dump implementation by Linus). A struct kmsg_dumper has > > been added which contains a callback to dump the kernel log buffers on > > crashes. The kmsg_dump function gets called from oops_exit() and panic() > > and invokes this callbacks with the crash reason. > > > > Signed-off-by: Simon Kagstrom > > Reviewed-by: Anders Grafstrom > > Reviewed-by: Ingo Molnar > > --- > > The bikeshed paint is drying: > > > > ChangeLog: > > * (Ingo Molnar): Flatten lock use > > * (Artem, Aaro): Fix style issues > > > > include/linux/kmsg_dump.h | 44 ++++++++++++++++++ > > kernel/panic.c | 3 + > > kernel/printk.c | 112 +++++++++++++++++++++++++++++++++++++++++++++ > > 3 files changed, 159 insertions(+), 0 deletions(-) > > create mode 100644 include/linux/kmsg_dump.h > > I wonder, via which tree this should go in. We are going to have mtdoops > depend on this. Should we go one of these ways: > > * this patch goes to one of Ingo's tip trees, so we can pull it and > work on top. > * we have Ingo's / Linus' acks, and this goes via the MTD tree. > ? Either way is good to me. Linus, do you have any preferences? Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/