Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932314AbZJSWhE (ORCPT ); Mon, 19 Oct 2009 18:37:04 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757553AbZJSWhD (ORCPT ); Mon, 19 Oct 2009 18:37:03 -0400 Received: from static-220-247-10-204.b-man.svips.gol.ne.jp ([220.247.10.204]:60631 "EHLO smtp.kamineko.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755895AbZJSWhC (ORCPT ); Mon, 19 Oct 2009 18:37:02 -0400 X-Greylist: delayed 386 seconds by postgrey-1.27 at vger.kernel.org; Mon, 19 Oct 2009 18:37:02 EDT Date: Tue, 20 Oct 2009 07:30:39 +0900 From: Mattia Dongili To: Arnd Bergmann Cc: John Kacur , linux-kernel@vger.kernel.org, Thomas Gleixner , Alan Cox , Ingo Molnar , Frederic Weisbecker Subject: Re: [PATCH] sony_pi: Remove the BKL from sonypi_misc_open Message-ID: <20091019223039.GA4367@kamineko.org> References: <200910190619.48037.arnd@arndb.de> <200910200000.24574.arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200910200000.24574.arnd@arndb.de> X-Message-Flag: Cranky? Try Free Software instead! X-Operating-System: Linux 2.6.32-rc4 x86_64 X-Editor: Vim http://www.vim.org/ X-Disclaimer: Buh! User-Agent: Mutt/1.5.20 (2009-06-14) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1227 Lines: 35 On Tue, Oct 20, 2009 at 12:00:24AM +0200, Arnd Bergmann wrote: > On Monday 19 October 2009, John Kacur wrote: > > How does this look? (Version 2 of the patch follows) > > Looks good now. Looks alright to me too. > > From efd07cfcd021b4438d83d383ab81f9b35cb41eb9 Mon Sep 17 00:00:00 2001 > > From: John Kacur > > Date: Sun, 18 Oct 2009 23:49:49 +0200 > > Subject: [PATCH] sony_pi: Remove the BKL from sonypi_misc_open > > > > The BKL is in this function because of the BKL pushdown > > (see commit f8f2c79d594463427f7114cedb1555110d547d89) > > > > It is not needed here because the mutex_lock sonypi_device.lock > > provides the necessary locking. > > > > sonpi_misc_ioctl can be converted to unlocked ioctls since it relies on > > its own locking (the mutex sonypi_device.lock) and not the bkl > > > > Signed-off-by: John Kacur > > Acked-by: Arnd Bergmann Acked-by: Mattia Dongili -- mattia :wq! -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/