Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758216AbZJTCLB (ORCPT ); Mon, 19 Oct 2009 22:11:01 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757355AbZJTCLA (ORCPT ); Mon, 19 Oct 2009 22:11:00 -0400 Received: from smtp.outflux.net ([198.145.64.163]:39319 "EHLO smtp.outflux.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757173AbZJTCLA (ORCPT ); Mon, 19 Oct 2009 22:11:00 -0400 Date: Mon, 19 Oct 2009 19:04:26 -0700 From: Kees Cook To: Arjan van de Ven Cc: Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, Pekka Enberg , Jan Beulich , Vegard Nossum , Yinghai Lu , Jeremy Fitzhardinge , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] [x86] detect and report lack of NX protections Message-ID: <20091020020426.GS5394@outflux.net> References: <20091019184234.GN5394@outflux.net> <20091020084335.4e8d97e9@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20091020084335.4e8d97e9@infradead.org> Organization: Canonical X-HELO: www.outflux.net Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2042 Lines: 60 It is possible for x86_64 systems to lack the NX bit (see check_efer()) either due to the hardware lacking support or the BIOS having turned off the CPU capability, so NX status should be reported. Additionally, anyone booting NX-capable CPUs in 32bit mode without PAE will lack NX functionality, so this change provides feedback for that case as well. v2: use "Alert:" instead of "Warning:" to avoid confusiong with WARN_ON() Signed-off-by: Kees Cook --- arch/x86/mm/init.c | 10 ++++++++++ arch/x86/mm/setup_nx.c | 2 ++ 2 files changed, 12 insertions(+), 0 deletions(-) diff --git a/arch/x86/mm/init.c b/arch/x86/mm/init.c index 73ffd55..8472293 100644 --- a/arch/x86/mm/init.c +++ b/arch/x86/mm/init.c @@ -149,6 +149,16 @@ unsigned long __init_refok init_memory_mapping(unsigned long start, set_nx(); if (nx_enabled) printk(KERN_INFO "NX (Execute Disable) protection: active\n"); + else if (cpu_has_pae) +#if defined(CONFIG_X86_64) || defined(CONFIG_X86_PAE) + /* PAE kernel, PAE CPU, without NX */ + printk(KERN_WARNING "Alert: NX (Execute Disable) protection " + "missing in CPU or disabled in BIOS!\n"); +#else + /* 32bit non-PAE kernel, PAE CPU */ + printk(KERN_WARNING "Alert: NX (Execute Disable) protection " + "cannot be enabled: non-PAE kernel!\n"); +#endif /* Enable PSE if available */ if (cpu_has_pse) diff --git a/arch/x86/mm/setup_nx.c b/arch/x86/mm/setup_nx.c index 513d8ed..b039a4c 100644 --- a/arch/x86/mm/setup_nx.c +++ b/arch/x86/mm/setup_nx.c @@ -53,6 +53,8 @@ void __init set_nx(void) #else void set_nx(void) { + /* notice if _PAGE_NX was removed during check_efer() */ + nx_enabled = ((__supported_pte_mask & _PAGE_NX) == _PAGE_NX); } #endif -- 1.6.3.3 -- Kees Cook Ubuntu Security Team -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/