Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754649AbZJTGHu (ORCPT ); Tue, 20 Oct 2009 02:07:50 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753447AbZJTGHt (ORCPT ); Tue, 20 Oct 2009 02:07:49 -0400 Received: from mail-fx0-f218.google.com ([209.85.220.218]:35373 "EHLO mail-fx0-f218.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753407AbZJTGHs (ORCPT ); Tue, 20 Oct 2009 02:07:48 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:date:from:to:cc:subject:message-id:mail-followup-to :references:mime-version:content-type:content-disposition :in-reply-to:x-url:user-agent; b=v5Lr43Bf0h+IINvOTFk2NW8ega1B8YZKjp0nagUQweydgowdw5TzNrwYh8o3Db48z2 TbaaBz9twbBRAY8ZgU3P5G1ttd4SmUZ+ZVrDRJAhrj1CJEqGuIBFgmvTYRsxHusISXLd x3pQoQWTa0o+y+S1+RsZQ7ddiN0lurODhlZ3E= Date: Tue, 20 Oct 2009 09:07:13 +0300 From: Amit Kucheria To: Samuel Ortiz Cc: List Linux Kernel , linux-omap@vger.kernel.org Subject: Re: [PATCH 1/5] mfd: twl4030-power: Rename DEVGROUP to DEV_GRP Message-ID: <20091020060713.GV32041@smtp.gmail.com> Mail-Followup-To: Samuel Ortiz , List Linux Kernel , linux-omap@vger.kernel.org References: <1255954211-28496-1-git-send-email-amit.kucheria@verdurent.com> <1255954244-28873-1-git-send-email-amit.kucheria@verdurent.com> <20091019192646.GC30203@sortiz.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20091019192646.GC30203@sortiz.org> X-URL: http://www.verdurent.com/ User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2981 Lines: 94 On 09 Oct 19, Samuel Ortiz wrote: > Hi Amit, > > I've applied patches 1,2 and 3 to my for-next branch. > I dont think patch 4 is really useful, and I'll wait for an ACK from Tony or > Nokia before pushing patch 5. > > Thanks for your work. > > Cheers, > Samuel. Samuel, I hope you meant you're taking patches 1, 2, 4 and 5. 3 is the one just moving stuff around and may be discarded. Thanks. Regards, Amit > On Mon, Oct 19, 2009 at 03:10:44PM +0300, Amit Kucheria wrote: > > Stick to the names used in the reference manual > > > > Signed-off-by: Amit Kucheria > > Cc: sameo@linux.intel.com > > Cc: linux-omap@vger.kernel.org > > --- > > drivers/mfd/twl4030-power.c | 16 ++++++++-------- > > 1 files changed, 8 insertions(+), 8 deletions(-) > > > > diff --git a/drivers/mfd/twl4030-power.c b/drivers/mfd/twl4030-power.c > > index d423e0c..82e3bcb 100644 > > --- a/drivers/mfd/twl4030-power.c > > +++ b/drivers/mfd/twl4030-power.c > > @@ -69,12 +69,12 @@ static u8 twl4030_start_script_address = 0x2b; > > > > /* resource configuration registers */ > > > > -#define DEVGROUP_OFFSET 0 > > +#define DEV_GRP_OFFSET 0 > > #define TYPE_OFFSET 1 > > > > -/* Bit positions */ > > -#define DEVGROUP_SHIFT 5 > > -#define DEVGROUP_MASK (7 << DEVGROUP_SHIFT) > > +/* Bit positions in the registers */ > > +#define DEV_GRP_SHIFT 5 > > +#define DEV_GRP_MASK (7 << DEV_GRP_SHIFT) > > #define TYPE_SHIFT 0 > > #define TYPE_MASK (7 << TYPE_SHIFT) > > #define TYPE2_SHIFT 3 > > @@ -328,7 +328,7 @@ static int __init twl4030_configure_resource(struct twl4030_resconfig *rconfig) > > > > /* Set resource group */ > > err = twl4030_i2c_read_u8(TWL4030_MODULE_PM_RECEIVER, &grp, > > - rconfig_addr + DEVGROUP_OFFSET); > > + rconfig_addr + DEV_GRP_OFFSET); > > if (err) { > > pr_err("TWL4030 Resource %d group could not be read\n", > > rconfig->resource); > > @@ -336,10 +336,10 @@ static int __init twl4030_configure_resource(struct twl4030_resconfig *rconfig) > > } > > > > if (rconfig->devgroup >= 0) { > > - grp &= ~DEVGROUP_MASK; > > - grp |= rconfig->devgroup << DEVGROUP_SHIFT; > > + grp &= ~DEV_GRP_MASK; > > + grp |= rconfig->devgroup << DEV_GRP_SHIFT; > > err = twl4030_i2c_write_u8(TWL4030_MODULE_PM_RECEIVER, > > - grp, rconfig_addr + DEVGROUP_OFFSET); > > + grp, rconfig_addr + DEV_GRP_OFFSET); > > if (err < 0) { > > pr_err("TWL4030 failed to program devgroup\n"); > > return err; > > -- > > 1.6.3.3 > > > > -- > Intel Open Source Technology Centre > http://oss.intel.com/ -- ------------------------------------------------------------ Amit Kucheria, Finland ------------------------------------------------------------ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/