Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754820AbZJTGM7 (ORCPT ); Tue, 20 Oct 2009 02:12:59 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751383AbZJTGM5 (ORCPT ); Tue, 20 Oct 2009 02:12:57 -0400 Received: from hera.kernel.org ([140.211.167.34]:40481 "EHLO hera.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753282AbZJTGM4 (ORCPT ); Tue, 20 Oct 2009 02:12:56 -0400 Message-ID: <4ADD5530.3050107@kernel.org> Date: Tue, 20 Oct 2009 15:14:08 +0900 From: Tejun Heo User-Agent: Thunderbird 2.0.0.23 (X11/20090817) MIME-Version: 1.0 To: Jiri Kosina CC: Jeff Mahoney , Peter Zijlstra , Linux Kernel Mailing List , Tony Luck , Fenghua Yu , linux-ia64@vger.kernel.org Subject: Re: Commit 34d76c41 causes linker errors on ia64 with NR_CPUS=4096 References: <4ADB967A.4080707@suse.com> <4ADD48D1.1040701@kernel.org> <4ADD54D4.70808@kernel.org> In-Reply-To: <4ADD54D4.70808@kernel.org> X-Enigmail-Version: 0.95.7 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.0 (hera.kernel.org [127.0.0.1]); Tue, 20 Oct 2009 06:12:56 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 934 Lines: 27 Tejun Heo wrote: > Jiri Kosina wrote: >> So how about something along the lines below? (completely untested as >> well) >> >> From: Jiri Kosina >> Subject: sched: move rq_weight data array out of .percpu >> >> Commit 34d76c41 introduced percpu array update_shares_data, size of which >> being proportional to NR_CPUS. Unfortunately this blows up ia64 for large >> NR_CPUS configuration, as ia64 allows only 64k for .percpu section. >> >> Fix this by allocating this array dynamically and keep only pointer to it >> percpu. > > Looks good to me from percpu POV. Oh... one thing. If you're doing dynamic allocation you can use nr_cpu_ids instead of NR_CPUS. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/