Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755454AbZJTGym (ORCPT ); Tue, 20 Oct 2009 02:54:42 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755349AbZJTGyl (ORCPT ); Tue, 20 Oct 2009 02:54:41 -0400 Received: from mailout-apollo.uni-duesseldorf.de ([134.99.128.36]:55530 "EHLO mail.rz.uni-duesseldorf.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754730AbZJTGyl (ORCPT ); Tue, 20 Oct 2009 02:54:41 -0400 MIME-version: 1.0 Content-transfer-encoding: 7BIT Content-type: TEXT/PLAIN; charset=US-ASCII Date: Tue, 20 Oct 2009 08:51:08 +0200 (CEST) From: Michael Schmitz Subject: Re: Fwd: [PATCH] [RFC] ataflop: remove buggy IRQ disable from do_fd_request() In-reply-to: To: Jiri Kosina Cc: Geert Uytterhoeven , linux-m68k , Tejun Heo , Jens Axboe , linux-kernel@vger.kernel.org Message-id: References: <10f740e80910100201n30367714uc57ec3c9c39b92af@mail.gmail.com> User-Agent: Alpine 2.00 (DEB 1167 2008-08-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1229 Lines: 35 Hi Jiri, > > > Please elaborate a little bit more which of the two points above you base > > > your NACK on. > > > > The removal of local_irq_disable() (which should have been local_irq_enable()) > > just raised a flag, and I didn't immediately see why the interrupt enable had > > been commented out. > > Yes, it has been commented out in a very non-intuitive way. That. too :-) What I meant to say - the reason why someone chose to comment out the original sti() wasn't really clear. I guess the reason for that particular change has been lost in the pre-git or bk era. > > With a bit of further thought on the matter I am satisfied that this patch will > > not impact on driver function at all, and do not wish to sustain my objection. > > > > IOW: Ack, and my sincere apologies for wasting your time. > > Thanks, I have added > > Acked-by: Michael Schmitz > > to the patch changelog in my tree. That's right ... Michael -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/