DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type;
        b=BWyLvb2x+26qEHNXClkdv2Yz9YaXFdN1fVm+lSqCGaLRYIW8XaZ2dxVjM5L44X6d0a
         yU3TiZkgst7exiiBH2VQvTkPJiLD5+hUcxKbIqmTPzr1bnBzBBWiT9kU776DWxOfTmdB
         fYmINKyPOQOw9YtWGg1M87o5BvUMv90QR5BjI=
MIME-Version: 1.0
In-Reply-To: <4ADE3225.5050001@caviumnetworks.com>
References: <1255819715-19763-1-git-send-email-linus.walleij@stericsson.com>
	 <alpine.LFD.2.00.0910200454300.2863@localhost.localdomain>
	 <4ADE3225.5050001@caviumnetworks.com>
Date: Wed, 21 Oct 2009 00:16:56 +0200
Message-ID: <63386a3d0910201516r71100657y92e3e6c2fab38db9@mail.gmail.com>
Subject: Re: [PATCH] Make MIPS dynamic clocksource/clockevent clock code 
	generic
From: Linus Walleij <linus.ml.walleij@gmail.com>
To: David Daney <ddaney@caviumnetworks.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
       Linus Walleij <linus.walleij@stericsson.com>,
       linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
       linux-mips@linux-mips.org, Mikael Pettersson <mikpe@it.uu.se>,
       Ralf Baechle <ralf@linux-mips.org>
Content-Type: text/plain; charset=ISO-8859-1
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 639
Lines: 17

2009/10/20 David Daney <ddaney@caviumnetworks.com>:

>> Please do not make that functions inline. They are too large and there
>> is no benefit of inlining them.
>
> If that is the case, then perhaps they should not be defined in a header
> file.

Of course not. There are apropriate places to put them, but as stated
I think the use as it is today warrants having them inlined.

Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/