Message-ID: <4ADE3D3C.1070608@caviumnetworks.com>
Date: Tue, 20 Oct 2009 15:44:12 -0700
From: David Daney <ddaney@caviumnetworks.com>
User-Agent: Thunderbird 2.0.0.21 (X11/20090320)
MIME-Version: 1.0
To: Linus Walleij <linus.ml.walleij@gmail.com>
CC: Thomas Gleixner <tglx@linutronix.de>,
       Linus Walleij <linus.walleij@stericsson.com>,
       linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
       linux-mips@linux-mips.org, Mikael Pettersson <mikpe@it.uu.se>,
       Ralf Baechle <ralf@linux-mips.org>
Subject: Re: [PATCH] Make MIPS dynamic clocksource/clockevent clock code 
 generic
References: <1255819715-19763-1-git-send-email-linus.walleij@stericsson.com>	 <alpine.LFD.2.00.0910200454300.2863@localhost.localdomain>	 <4ADE3225.5050001@caviumnetworks.com> <63386a3d0910201516r71100657y92e3e6c2fab38db9@mail.gmail.com>
In-Reply-To: <63386a3d0910201516r71100657y92e3e6c2fab38db9@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 834
Lines: 22

Linus Walleij wrote:
> 2009/10/20 David Daney <ddaney@caviumnetworks.com>:
> 
>>> Please do not make that functions inline. They are too large and there
>>> is no benefit of inlining them.
>> If that is the case, then perhaps they should not be defined in a header
>> file.
> 
> Of course not. There are apropriate places to put them, but as stated
> I think the use as it is today warrants having them inlined.
> 

I wasn't trying to imply that they shouldn't be inlined, only that if 
you  choose (as you did) to define them in a header file, that they 
*should* be inline.

David Daney
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/