Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753861AbZJUOiJ (ORCPT ); Wed, 21 Oct 2009 10:38:09 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753745AbZJUOiH (ORCPT ); Wed, 21 Oct 2009 10:38:07 -0400 Received: from fmmailgate07.web.de ([217.72.192.248]:33876 "EHLO fmmailgate07.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753682AbZJUOiD (ORCPT ); Wed, 21 Oct 2009 10:38:03 -0400 Date: Wed, 21 Oct 2009 16:38:06 +0200 Message-Id: <1394923769@web.de> MIME-Version: 1.0 From: Thomas Schlichter To: Jan Beulich Cc: Arjan van de Ven , dri-devel@lists.sourceforge.net, Robert Hancock , Henrique de Moraes Holschuh , "H. Peter Anvin" , jbarnes@virtuousgeek.org, Jeremy Fitzhardinge , linux-kernel@vger.kernel.org, Ingo Molnar , Ingo Molnar , Suresh Siddha , Thomas Gleixner , Thomas Hellstrom , Tejun Heo , Venkatesh Pallipadi , x86@kernel.org, Yinghai Lu Subject: =?iso-8859-15?Q?Re:_[RFC_Patch]_use_MTRR_for_write_combining_if_PAT_is?= =?iso-8859-15?Q?_not__available?= Organization: http://freemail.web.de/ X-Provags-Id: V01U2FsdGVkX18/TnW5KhxcrsXi2FQH1R9dwb6v/hY2yGOGNCPspnIYDvOI5 VlKYfh3zpyWrf0M4LdztzhyvbhGapL2oHidtAQLSP/fl9CDs3K00bZVoT6oN Q== Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1256 Lines: 31 Jan Beulich wrote: > >Yes, I had that in the first place, but Jan suggested to extend it to also > >handle non-aligned, non-power-of-two cases: > > http://marc.info/?l=linux-kernel&m=125541951529918&w=2 > > I merely pointed out it wouldn't work for unaligned addresses or sizes > passed in. Oh, I'm sorry, I must have misinterpreted it... > >So if it's OK for Jan, I'll reduce the functionality again and use mtrr_add() > >instead. Btw. this simply means to drop mtrr_add_unaligned(), all the other > >parts are still required for reference counting and a proper mtrr_del() on file > >close. > > I'm perfectly fine with just handling the aligned case, as long as the code > checks that the alignment constraints are met. Hmm, as far as I see mtrr_add() and mtrr_add_page() already check these constraints. Do you want me to check them additionally? Or do you want to completely fail the mmap() if these constraints are violated? I'd let mmap() succeed even if the mtrr_add() fails... Regards, Thomas -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/