Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753937AbZJUPNs (ORCPT ); Wed, 21 Oct 2009 11:13:48 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753500AbZJUPNr (ORCPT ); Wed, 21 Oct 2009 11:13:47 -0400 Received: from vpn.id2.novell.com ([195.33.99.129]:10322 "EHLO vpn.id2.novell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751307AbZJUPNr convert rfc822-to-8bit (ORCPT ); Wed, 21 Oct 2009 11:13:47 -0400 Message-Id: <4ADF4184020000780001B25B@vpn.id2.novell.com> X-Mailer: Novell GroupWise Internet Agent 8.0.1 Date: Wed, 21 Oct 2009 16:14:44 +0100 From: "Jan Beulich" To: "Thomas Schlichter" Cc: "Jeremy Fitzhardinge" , "Ingo Molnar" , "Robert Hancock" , "Henrique de Moraes Holschuh" , "Suresh Siddha" , "Venkatesh Pallipadi" , "Tejun Heo" , , "Yinghai Lu" , "Thomas Gleixner" , "Arjan van de Ven" , , "Ingo Molnar" , , , "Thomas Hellstrom" , "H. Peter Anvin" Subject: Re: [RFC Patch] use MTRR for write combining if PAT is not available References: <1394923769@web.de> In-Reply-To: <1394923769@web.de> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8BIT Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 713 Lines: 19 >>> Thomas Schlichter 21.10.09 16:38 >>> >Hmm, as far as I see mtrr_add() and mtrr_add_page() already check these >constraints. Do you want me to check them additionally? Or do you want to >completely fail the mmap() if these constraints are violated? I'd say you should check it explicitly in the caller, to avoid the warning message being printed otherwise. >I'd let mmap() succeed even if the mtrr_add() fails... Yes, of course. Jan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/