Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755683AbZJUWUO (ORCPT ); Wed, 21 Oct 2009 18:20:14 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755007AbZJUWUO (ORCPT ); Wed, 21 Oct 2009 18:20:14 -0400 Received: from mga05.intel.com ([192.55.52.89]:14516 "EHLO fmsmga101.fm.intel.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754762AbZJUWUN (ORCPT ); Wed, 21 Oct 2009 18:20:13 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.44,600,1249282800"; d="scan'208";a="738962367" Date: Thu, 22 Oct 2009 00:22:11 +0200 From: Samuel Ortiz To: Ilkka Koskinen Cc: linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org Subject: Re: [Resend PATCH 1/2] twl4030: Do not dereference null pointer in error path Message-ID: <20091021222210.GC17796@sortiz.org> References: <1256044973-14548-1-git-send-email-ilkka.koskinen@nokia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1256044973-14548-1-git-send-email-ilkka.koskinen@nokia.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1192 Lines: 40 Hi Ilkka, On Tue, Oct 20, 2009 at 04:22:52PM +0300, Ilkka Koskinen wrote: > Signed-off-by: Ilkka Koskinen Patch applied to my for-linus and for-next branches. I'll try to get that one merged for 2.6.32. Cheers, Samuel. > --- > drivers/mfd/twl4030-core.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/mfd/twl4030-core.c b/drivers/mfd/twl4030-core.c > index e424cf6..8cf0a02 100644 > --- a/drivers/mfd/twl4030-core.c > +++ b/drivers/mfd/twl4030-core.c > @@ -792,7 +792,7 @@ twl4030_probe(struct i2c_client *client, const struct i2c_device_id *id) > twl->client = i2c_new_dummy(client->adapter, > twl->address); > if (!twl->client) { > - dev_err(&twl->client->dev, > + dev_err(&client->dev, > "can't attach client %d\n", i); > status = -ENOMEM; > goto fail; > -- > 1.6.0.4 > -- Intel Open Source Technology Centre http://oss.intel.com/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/