Date: Wed, 21 Oct 2009 19:48:22 -0700
From: Arjan van de Ven <arjan@infradead.org>
To: Andi Kleen <andi@firstfloor.org>
Cc: john stultz <johnstul@us.ibm.com>, Andi Kleen <andi@firstfloor.org>,
       lkml <linux-kernel@vger.kernel.org>, Mike Fulton <fultonm@ca.ibm.com>,
       Sean Foley <Sean_Foley@ca.ibm.com>, Darren Hart <dvhltc@us.ibm.com>
Subject: Re: [RFC][PATCH] Add prctl to set sibling thread names
Message-ID: <20091021194822.72895c46@infradead.org>
In-Reply-To: <20091022004919.GT32470@one.firstfloor.org>
References: <1256167297.4768.14.camel@localhost.localdomain>
	<20091021174804.3885db37@infradead.org>
	<20091022004919.GT32470@one.firstfloor.org>
Organization: Intel
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 841
Lines: 23

On Thu, 22 Oct 2009 02:49:19 +0200
Andi Kleen <andi@firstfloor.org> wrote:

> > you're pretty much the first now who touches ->comm from
> > not-the-thread-itself.... are you sure that is safe?
> 
> It's not, there is no locking. On the other hand nothing should crash,
> just users might see half rewritten data.

.. with strings this is tricky though.. if the new string is longer
than the old one the terminating zero might just be missed etc.


-- 
Arjan van de Ven 	Intel Open Source Technology Centre
For development, discussion and tips for power savings, 
visit http://www.lesswatts.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/