Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753891AbZJVCwY (ORCPT ); Wed, 21 Oct 2009 22:52:24 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752908AbZJVCwX (ORCPT ); Wed, 21 Oct 2009 22:52:23 -0400 Received: from bombadil.infradead.org ([18.85.46.34]:44489 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752013AbZJVCwX (ORCPT ); Wed, 21 Oct 2009 22:52:23 -0400 Date: Wed, 21 Oct 2009 22:52:24 -0400 From: Christoph Hellwig To: Arnd Bergmann Cc: John Kacur , linux-kernel@vger.kernel.org, Thomas Gleixner , Alan Cox , Ingo Molnar , Frederic Weisbecker , Mattia Dongili Subject: Re: [PATCH] sony_pi: Remove the BKL from sonypi_misc_open Message-ID: <20091022025224.GA17438@infradead.org> References: <200910200008.57468.arnd@arndb.de> <200910211029.21702.arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200910211029.21702.arnd@arndb.de> User-Agent: Mutt/1.5.19 (2009-01-05) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 677 Lines: 14 On Wed, Oct 21, 2009 at 10:29:21AM +0200, Arnd Bergmann wrote: > Well, for this specific case, the driver does not actually need to seek, > because the read function never looks at the position and there is no > write function. For annotation purposes, IMHO we should have a simple > '.llseek = no_llseek' in there. Which is normal for character drivers. Even better you should use nonseekable_open to also prevent pread/pwrite. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/