Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755700AbZJVMvO (ORCPT ); Thu, 22 Oct 2009 08:51:14 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755382AbZJVMvN (ORCPT ); Thu, 22 Oct 2009 08:51:13 -0400 Received: from gir.skynet.ie ([193.1.99.77]:53981 "EHLO gir.skynet.ie" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754840AbZJVMvM (ORCPT ); Thu, 22 Oct 2009 08:51:12 -0400 Date: Thu, 22 Oct 2009 13:51:20 +0100 From: Mel Gorman To: Pekka Enberg Cc: David Rientjes , Jiri Kosina , Stephan von Krawczynski , linux-kernel , Greg Kroah-Hartman , Alan Cox , Frans Pop , Peter Zijlstra , Andrew Morton , Linus Torvalds , Christoph Lameter Subject: Re: page allocation failure message kernel 2.6.31.4 (tty-related) Message-ID: <20091022125120.GN11778@csn.ul.ie> References: <20091020153838.665bc39c.skraw@ithnet.com> <20091022105902.GM11778@csn.ul.ie> <84144f020910220536k61d43e95x802c2391459e4305@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <84144f020910220536k61d43e95x802c2391459e4305@mail.gmail.com> User-Agent: Mutt/1.5.17+20080114 (2008-01-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3103 Lines: 78 On Thu, Oct 22, 2009 at 03:36:04PM +0300, Pekka Enberg wrote: > On Thu, Oct 22, 2009 at 1:59 PM, Mel Gorman wrote: > >> There's subtleties like where rt tasks are given ALLOC_HARDER even when > >> in_interrupt() that are different from previous kernels and could reduce > >> the amount of ALLOC_HIGH and ALLOC_HARDER memory that can be allocated. > >> > > > > /me checks again > > > > I think you're right. Correct it with something like? > > > > ==== CUT HERE ==== > > From bca71e94e10cd93771ec5b17eccb817dd0c85360 Mon Sep 17 00:00:00 2001 > > From: Mel Gorman > > Date: Thu, 22 Oct 2009 11:55:14 +0100 > > Subject: [PATCH] page allocator: Do not allow interrupts to use ALLOC_HARDER > > > > Commit 341ce06f69abfafa31b9468410a13dbd60e2b237 altered watermark logic > > slightly by allowing rt_tasks that are handling an interrupt to set > > ALLOC_HARDER. This patch brings the watermark logic more in line with > > 2.6.30. > > > > Signed-off-by: Mel Gorman > > Good catch. > > Reviewed-by: Pekka Enberg > > Can we have some of the people that are hitting the OOM problems test > this patch in combination with this patch: > > http://patchwork.kernel.org/patch/54215/ > > Mel, can you also resend these page allocator patches to Andrew? I > haven't seen him pick the above patch in -mm and we probably want to > get fixes into -stable soon because distributors seem to be basing > their next releases on 2.6.31... > What I'm going to do is prepare a set that assembles all the possible patches that fix the variety of errors and get people to retest to make sure we catch what is relevant, what isn't and what bugs (if any) are left. I should have the set ready by the end of the day. > > --- > > ?mm/page_alloc.c | ? ?2 +- > > ?1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > > index a3e5fed..3ecf819 100644 > > --- a/mm/page_alloc.c > > +++ b/mm/page_alloc.c > > @@ -1769,7 +1769,7 @@ gfp_to_alloc_flags(gfp_t gfp_mask) > > ? ? ? ? ? ? ? ? * See also cpuset_zone_allowed() comment in kernel/cpuset.c. > > ? ? ? ? ? ? ? ? */ > > ? ? ? ? ? ? ? ?alloc_flags &= ~ALLOC_CPUSET; > > - ? ? ? } else if (unlikely(rt_task(p))) > > + ? ? ? } else if (unlikely(rt_task(p)) && !in_interrupt()) > > ? ? ? ? ? ? ? ?alloc_flags |= ALLOC_HARDER; > > > > ? ? ? ?if (likely(!(gfp_mask & __GFP_NOMEMALLOC))) { > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > > the body of a message to majordomo@vger.kernel.org > > More majordomo info at ?http://vger.kernel.org/majordomo-info.html > > Please read the FAQ at ?http://www.tux.org/lkml/ > > > -- Mel Gorman Part-time Phd Student Linux Technology Center University of Limerick IBM Dublin Software Lab -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/