Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756428AbZJVOrL (ORCPT ); Thu, 22 Oct 2009 10:47:11 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756043AbZJVOrK (ORCPT ); Thu, 22 Oct 2009 10:47:10 -0400 Received: from mail-qy0-f194.google.com ([209.85.221.194]:55390 "EHLO mail-qy0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756031AbZJVOrH convert rfc822-to-8bit (ORCPT ); Thu, 22 Oct 2009 10:47:07 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=gOegoj+zJiC74p4TnRwiu3D4CwW/LeM5hJSt4fRdhze6W20C89wEy2fF9pybvvMLrB ZBo1UUz/G9r6pIqAPPzuxvhAB3qA4YylrUl0g7j6Xa8L+S84WhpgtMaYMWVqIL7cWGbf eE0OnsMxAW9wK7e+52TOgD+bV2vp5wZA/fY48= MIME-Version: 1.0 In-Reply-To: <1256221356-26049-1-git-send-email-mel@csn.ul.ie> References: <1256221356-26049-1-git-send-email-mel@csn.ul.ie> Date: Thu, 22 Oct 2009 17:47:10 +0300 X-Google-Sender-Auth: 7611312378255941 Message-ID: <84144f020910220747nba30d8bkc83c2569da79bd7c@mail.gmail.com> Subject: Re: [PATCH 0/5] Candidate fix for increased number of GFP_ATOMIC failures V2 From: Pekka Enberg To: Mel Gorman Cc: Frans Pop , Jiri Kosina , Sven Geggus , Karol Lewandowski , Tobias Oetiker , "Rafael J. Wysocki" , David Miller , Reinette Chatre , Kalle Valo , David Rientjes , KOSAKI Motohiro , Mohamed Abbas , Jens Axboe , "John W. Linville" , Bartlomiej Zolnierkiewicz , Greg Kroah-Hartman , Stephan von Krawczynski , Kernel Testers List , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, "linux-mm@kvack.org\"" , akpm@linux-foundation.org, cl@linux-foundation.org, torvalds@linux-foundation.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1633 Lines: 31 On Thu, Oct 22, 2009 at 5:22 PM, Mel Gorman wrote: > Test 1: Verify your problem occurs on 2.6.32-rc5 if you can > > Test 2: Apply the following two patches and test again > > ?1/5 page allocator: Always wake kswapd when restarting an allocation attempt after direct reclaim failed > ?2/5 page allocator: Do not allow interrupts to use ALLOC_HARDER These are pretty obvious bug fixes and should go to linux-next ASAP IMHO. > Test 5: If things are still screwed, apply the following > ?5/5 Revert 373c0a7e, 8aa7e847: Fix congestion_wait() sync/async vs read/write confusion > > ? ? ? ?Frans Pop reports that the bulk of his problems go away when this > ? ? ? ?patch is reverted on 2.6.31. There has been some confusion on why > ? ? ? ?exactly this patch was wrong but apparently the conversion was not > ? ? ? ?complete and further work was required. It's unknown if all the > ? ? ? ?necessary work exists in 2.6.31-rc5 or not. If there are still > ? ? ? ?allocation failures and applying this patch fixes the problem, > ? ? ? ?there are still snags that need to be ironed out. As explained by Jens Axboe, this changes timing but is not the source of the OOMs so the revert is bogus even if it "helps" on some workloads. IIRC the person who reported the revert to help things did report that the OOMs did not go away, they were simply harder to trigger with the revert. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/