Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756257AbZJVSA1 (ORCPT ); Thu, 22 Oct 2009 14:00:27 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756138AbZJVSA0 (ORCPT ); Thu, 22 Oct 2009 14:00:26 -0400 Received: from hrndva-omtalb.mail.rr.com ([71.74.56.122]:43767 "EHLO hrndva-omtalb.mail.rr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756129AbZJVSAZ (ORCPT ); Thu, 22 Oct 2009 14:00:25 -0400 Subject: Re: [PATCH -v4 9/9] tracing: add function graph tracer support for MIPS From: Steven Rostedt Reply-To: rostedt@goodmis.org To: David Daney Cc: wuzhangjin@gmail.com, linux-kernel@vger.kernel.org, linux-mips@linux-mips.org, Thomas Gleixner , Ralf Baechle , Nicholas Mc Guire In-Reply-To: <4AE08559.40806@caviumnetworks.com> References: <028867b99ec532b84963a35e7d552becc783cafc.1256135456.git.wuzhangjin@gmail.com> <96110ea5dd4d3d54eb97d0bb708a5bd81c7a50b5.1256135456.git.wuzhangjin@gmail.com> <5dda13e8e3a9c9dba4bb7179183941bda502604f.1256135456.git.wuzhangjin@gmail.com> <53bdfdd95ec4fa00d4cc505bb5972cf21243a14d.1256135456.git.wuzhangjin@gmail.com> <1256141540.18347.3118.camel@gandalf.stny.rr.com> <4ADF38D5.9060100@caviumnetworks.com> <1256143568.18347.3169.camel@gandalf.stny.rr.com> <4ADF3FE0.5090104@caviumnetworks.com> <1256145813.18347.3210.camel@gandalf.stny.rr.com> <1256211516.3852.47.camel@falcon> <4AE08173.7070500@caviumnetworks.com> <1256227916.20866.784.camel@gandalf.stny.rr.com> <4AE08559.40806@caviumnetworks.com> Content-Type: text/plain Organization: Kihon Technologies Inc. Date: Thu, 22 Oct 2009 14:00:28 -0400 Message-Id: <1256234428.20866.797.camel@gandalf.stny.rr.com> Mime-Version: 1.0 X-Mailer: Evolution 2.26.3 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 699 Lines: 21 On Thu, 2009-10-22 at 09:16 -0700, David Daney wrote: > Steven Rostedt wrote: > > Functions that run off into another function?? I guess the compiler > > could do that, but with -pg enable, I would think is broken. > > > > Use of GCC-4.5's __builtin_unreachable() can lead to this, as well as > functions that call noreturn functions. But still. Should that unreachable code have a "save ra to stack"? If not, this method is still safe. -- Steve -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/