Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756851AbZJVVoh (ORCPT ); Thu, 22 Oct 2009 17:44:37 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755956AbZJVVog (ORCPT ); Thu, 22 Oct 2009 17:44:36 -0400 Received: from pfepa.post.tele.dk ([195.41.46.235]:54681 "EHLO pfepa.post.tele.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755906AbZJVVog (ORCPT ); Thu, 22 Oct 2009 17:44:36 -0400 Date: Thu, 22 Oct 2009 23:44:39 +0200 From: Sam Ravnborg To: Vlad Yasevich Cc: Amerigo Wang , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, akpm@linux-foundation.org Subject: Re: [Patch] sctp: remove deprecated SCTP_GET_*_OLD stuffs Message-ID: <20091022214439.GA2635@merkur.ravnborg.org> References: <20091015082849.4605.48311.sendpatchset@localhost.localdomain> <4AE0C64A.9080400@hp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4AE0C64A.9080400@hp.com> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1862 Lines: 37 On Thu, Oct 22, 2009 at 04:53:30PM -0400, Vlad Yasevich wrote: > > diff --git a/include/net/sctp/user.h b/include/net/sctp/user.h > > index be2334a..0991f1b 100644 > > --- a/include/net/sctp/user.h > > +++ b/include/net/sctp/user.h > > @@ -131,14 +131,6 @@ enum sctp_optname { > > #define SCTP_SOCKOPT_BINDX_REM SCTP_SOCKOPT_BINDX_REM > > SCTP_SOCKOPT_PEELOFF, /* peel off association. */ > > #define SCTP_SOCKOPT_PEELOFF SCTP_SOCKOPT_PEELOFF > > - SCTP_GET_PEER_ADDRS_NUM_OLD, /* Get number of peer addresss. */ > > -#define SCTP_GET_PEER_ADDRS_NUM_OLD SCTP_GET_PEER_ADDRS_NUM_OLD > > - SCTP_GET_PEER_ADDRS_OLD, /* Get all peer addresss. */ > > -#define SCTP_GET_PEER_ADDRS_OLD SCTP_GET_PEER_ADDRS_OLD > > - SCTP_GET_LOCAL_ADDRS_NUM_OLD, /* Get number of local addresss. */ > > -#define SCTP_GET_LOCAL_ADDRS_NUM_OLD SCTP_GET_LOCAL_ADDRS_NUM_OLD > > - SCTP_GET_LOCAL_ADDRS_OLD, /* Get all local addresss. */ > > -#define SCTP_GET_LOCAL_ADDRS_OLD SCTP_GET_LOCAL_ADDRS_OLD > > SCTP_SOCKOPT_CONNECTX_OLD, /* CONNECTX old requests. */ > > After running the regression suite against this patch I find that we can't > remove the enum values. Removing the enums changes the value for the remainder > of the definitions and breaks binary compatibility for applications that use > those trailing options. > > You should be ok with removing the #defines and actual code that uses them, > but not the enums. You can even rename the enums, but we must preserve > numeric ordering. If we really depend on the actual value of an enum as in this case, then e should assign them direct to better document this. Sam -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/