Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752154AbZJWOqe (ORCPT ); Fri, 23 Oct 2009 10:46:34 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752044AbZJWOqe (ORCPT ); Fri, 23 Oct 2009 10:46:34 -0400 Received: from xc.sipsolutions.net ([83.246.72.84]:45844 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751607AbZJWOqc (ORCPT ); Fri, 23 Oct 2009 10:46:32 -0400 Subject: Re: [PATCH] net: Adjust softirq raising in __napi_schedule From: Johannes Berg To: Tilman Schmidt Cc: Jarek Poplawski , David Miller , hidave.darkstar@gmail.com, linux-kernel@vger.kernel.org, tglx@linutronix.de, linux-wireless@vger.kernel.org, linux-ppp@vger.kernel.org, netdev@vger.kernel.org, paulus@samba.org, Michael Buesch , Oliver Hartkopp In-Reply-To: <4AE1C00B.5010008@imap.cc> References: <4AD31213.6020006@imap.cc> <20091015114052.GA9870@ff.dom.local> <4AD76184.6030900@gmail.com> <4ADF5710.4030505@imap.cc> <20091021211906.GA11401@ami.dom.local> <1256160330.12174.2.camel@johannes.local> <20091021213947.GA12202@ami.dom.local> <1256200021.12174.11.camel@johannes.local> <4AE1C00B.5010008@imap.cc> Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-GtZNVJ+WCQlMSt3LTX9e" Date: Fri, 23 Oct 2009 16:46:31 +0200 Message-Id: <1256309191.12174.51.camel@johannes.local> Mime-Version: 1.0 X-Mailer: Evolution 2.28.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1829 Lines: 50 --=-GtZNVJ+WCQlMSt3LTX9e Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, 2009-10-23 at 16:39 +0200, Tilman Schmidt wrote: > Strange. Then what are the two separate functions netif_rx() and > netif_rx_ni() for? netif_rx_ni() disables preemption. > > This really should be obvious. You're fixing the warning at the source > > of the warning, rather than the source of the problem. >=20 > Good idea. So please do tell us where the source of the problem is. You use netif_rx_ni() instead of netif_rx() at whatever place that causes this problem. johannes --=-GtZNVJ+WCQlMSt3LTX9e Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- iQIcBAABAgAGBQJK4cHEAAoJEODzc/N7+QmaStYQAK+3IL2OlaRETBYjrgvNL4zi rKCKbYSxUYdNmwIn9ldy/eXm37pYN/wNVY7CeoVzfNeS3nxXMhKd7D/hetFtK7n9 JGjlf+6kY8el0k/6PCEVdarfvIujHJXADdVnG10LZoLb3YSM2wSeIPvPfoSb10XS Jf+8azFy0Arg2nqRJLflslV3y2YnD9fGDb9uLmcIP2/PPBbmkkz9j7Nm4saM0TNj 06ugJpg8aJawsuLr3K1IlPCucTIiDxhU9e/d4zwZYJxHJpsikMYQkuA+tqTSTmBo bW8iNHzNWfb1SkMkkKBbvau0Nb9mANDciLVt9T9r+e9ccTB1hqfRY51NCB2lwNOF BFhpr1fRqZ40DouMp7umzbRvR8dyljl8Hvs1NGOJwY1xGVyOMsKMr63EbSN6BiWM bCPKpnFbXfOFjevctO2D3Dk058WhTGXgmW3choBpCxCZRwS89zrlkMO/evjxx3Yg D/jlHlHo8u4AIaGAQcDmDifXBCoihnx9+N2Sbt/OKnmexLmY7EvEpgXfNCgj+eKB KI0vd0Xl/ayjQ8nreS9bD4Oco9g528izVHxvUPI+OUyE0VqZee/TjvAkZ4psSaKg x1JzBsTZGxALQxPcQ4UbSBxkFYZLrWkToJ8aVegQnsPl4ijzke3q0S1VaHpfHawi 8znqqSJ/No+Hf2EoXX/D =Xf17 -----END PGP SIGNATURE----- --=-GtZNVJ+WCQlMSt3LTX9e-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/