Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751708AbZJWVnS (ORCPT ); Fri, 23 Oct 2009 17:43:18 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751565AbZJWVnR (ORCPT ); Fri, 23 Oct 2009 17:43:17 -0400 Received: from g5t0009.atlanta.hp.com ([15.192.0.46]:11462 "EHLO g5t0009.atlanta.hp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751543AbZJWVnJ (ORCPT ); Fri, 23 Oct 2009 17:43:09 -0400 From: Bjorn Helgaas To: Ike Panhc Subject: Re: [Resend] [PATCH] ACPI: New driver for Lenovo SL laptops Date: Fri, 23 Oct 2009 15:43:10 -0600 User-Agent: KMail/1.9.10 Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, Alexandre Rostovtsev References: <1253805163-12493-1-git-send-email-ike.pan@canonical.com> <1256325108-22626-1-git-send-email-ike.pan@canonical.com> In-Reply-To: <1256325108-22626-1-git-send-email-ike.pan@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200910231543.12254.bjorn.helgaas@hp.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 810 Lines: 28 On Friday 23 October 2009 01:11:48 pm Ike Panhc wrote: > +static int __init lenovo_sl_laptop_init(void) > +{ > + int ret; > + acpi_status status; > + > + if (acpi_disabled) > + return -ENODEV; Don't need this. > + lenovo_sl_laptop_hkey_handle = lenovo_sl_laptop_ec0_handle = NULL; > + status = acpi_get_handle(NULL, ACPI_HKEY_PATH, > + &lenovo_sl_laptop_hkey_handle); > + if (ACPI_FAILURE(status)) { > + pr_err("Failed to get ACPI handle for %s\n", ACPI_HKEY_PATH); > + return -ENODEV; > + } Don't need this; acpi_bus_register_driver() is enough. Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/