Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753820AbZJXORX (ORCPT ); Sat, 24 Oct 2009 10:17:23 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753808AbZJXORU (ORCPT ); Sat, 24 Oct 2009 10:17:20 -0400 Received: from mail-ew0-f208.google.com ([209.85.219.208]:37522 "EHLO mail-ew0-f208.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753804AbZJXORS (ORCPT ); Sat, 24 Oct 2009 10:17:18 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; b=pF19weqBDx+XUxim+5iPN/uUsTAO8yxzKC+GonbtO/nBeXFBWt44KBRePxG97cbpCQ 7ourLMvbJUSGds9bjMwAlZ6P4itPyXHSoa6wZhaXv0+hAtjhMiNES8sePjUmxNHtbXmW bbXxg7lwSkVu/eWCw2qJfj2+00TrJ+GQjLvmg= From: Frederic Weisbecker To: Ingo Molnar Cc: LKML , Paul Mundt , Ingo Molnar , Alan Stern , Frederic Weisbecker Subject: [PATCH 2/6] x86/hw-breakpoints: Actually flush thread breakpoints in flush_thread(). Date: Sat, 24 Oct 2009 16:16:54 +0200 Message-Id: <1256393818-8921-3-git-send-email-fweisbec@gmail.com> X-Mailer: git-send-email 1.6.2.3 In-Reply-To: <1256393818-8921-1-git-send-email-fweisbec@gmail.com> References: <1256393818-8921-1-git-send-email-fweisbec@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1615 Lines: 45 From: Paul Mundt flush_thread() tries to do a TIF_DEBUG check before calling in to flush_thread_hw_breakpoint() (which subsequently clears the thread flag), but for some reason, the x86 code is manually clearing TIF_DEBUG immediately before the test, so this path will never be taken. This kills off the erroneous clear_tsk_thread_flag() and lets flush_thread_hw_breakpoint() actually get invoked. Presumably folks were getting lucky with testing and the free_thread_info() -> free_thread_xstate() path was taking care of the flush there. Signed-off-by: Paul Mundt Acked-by: "K.Prasad" Cc: Ingo Molnar Cc: Alan Stern LKML-Reference: <20091005102306.GA7889@linux-sh.org> Signed-off-by: Frederic Weisbecker --- arch/x86/kernel/process.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/arch/x86/kernel/process.c b/arch/x86/kernel/process.c index 2275ce5..cf8ee00 100644 --- a/arch/x86/kernel/process.c +++ b/arch/x86/kernel/process.c @@ -107,8 +107,6 @@ void flush_thread(void) } #endif - clear_tsk_thread_flag(tsk, TIF_DEBUG); - if (unlikely(test_tsk_thread_flag(tsk, TIF_DEBUG))) flush_thread_hw_breakpoint(tsk); memset(tsk->thread.tls_array, 0, sizeof(tsk->thread.tls_array)); -- 1.6.2.3 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/