Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754113AbZJYUfd (ORCPT ); Sun, 25 Oct 2009 16:35:33 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753840AbZJYUfd (ORCPT ); Sun, 25 Oct 2009 16:35:33 -0400 Received: from earthlight.etchedpixels.co.uk ([81.2.110.250]:56292 "EHLO www.etchedpixels.co.uk" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753707AbZJYUfc (ORCPT ); Sun, 25 Oct 2009 16:35:32 -0400 Date: Sun, 25 Oct 2009 20:37:05 +0000 From: Alan Cox To: Tilman Schmidt Cc: David Miller , Karsten Keil , Hansjoerg Lipp , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, isdn4linux@listserv.isdn4linux.de, i4ldeveloper@listserv.isdn4linux.de Subject: Re: [PATCH 6/9] ser_gigaset: checkpatch cleanup Message-ID: <20091025203705.273e1c14@lxorguk.ukuu.org.uk> In-Reply-To: <20091023-patch-gigaset-06.tilman@imap.cc> References: <20091023-patch-gigaset-00.tilman@imap.cc> <20091023-patch-gigaset-06.tilman@imap.cc> X-Mailer: Claws Mail 3.7.2 (GTK+ 2.14.7; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 710 Lines: 24 On Sun, 25 Oct 2009 20:30:27 +0100 (CET) Tilman Schmidt wrote: > Duly uglified as demanded by checkpatch.pl. > > Impact: cosmeti Umm ?? > - if (!(bcs->tx_skb = skb_dequeue(&bcs->squeue))) > + nextskb = skb_dequeue(&bcs->squeue); > + if (!nextskb) > /* no skb either, nothing to do */ > return; > + bcs->tx_skb = nextskb; This does not do the same thing as before Previously the NULL case assigned to bcs->tx_skb, now it does not. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/