Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754520AbZJZByE (ORCPT ); Sun, 25 Oct 2009 21:54:04 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754507AbZJZByD (ORCPT ); Sun, 25 Oct 2009 21:54:03 -0400 Received: from bombadil.infradead.org ([18.85.46.34]:53435 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754503AbZJZBx7 (ORCPT ); Sun, 25 Oct 2009 21:53:59 -0400 Subject: Re: [PATCH 3/3] sched: Disable affine wakeups by default From: Peter Zijlstra To: Mike Galbraith Cc: Arjan van de Ven , mingo@elte.hu, linux-kernel@vger.kernel.org In-Reply-To: <1256508287.17306.14.camel@marge.simson.net> References: <20091024125853.35143117@infradead.org> <20091024130432.0c46ef27@infradead.org> <20091024130728.051c4d7c@infradead.org> <1256453725.12138.40.camel@marge.simson.net> <20091025095109.449bac9e@infradead.org> <1256492289.14241.40.camel@marge.simson.net> <20091025123319.2b76bf69@infradead.org> <1256508287.17306.14.camel@marge.simson.net> Content-Type: text/plain Date: Mon, 26 Oct 2009 02:53:55 +0100 Message-Id: <1256522035.7356.19.camel@laptop> Mime-Version: 1.0 X-Mailer: Evolution 2.26.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 687 Lines: 14 On Sun, 2009-10-25 at 23:04 +0100, Mike Galbraith wrote: > if (want_affine && (tmp->flags & SD_WAKE_AFFINE) && > - cpumask_test_cpu(prev_cpu, sched_domain_span(tmp))) { > + (level == SD_LV_SIBLING || level == SD_LV_MC)) { quick comment without actually having looked at the patch, we should really get rid of sd->level and encode properties of the sched domains in sd->flags. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/