Date: Mon, 26 Oct 2009 12:35:55 +0100
From: Jens Axboe <jens.axboe@oracle.com>
To: Shaohua Li <shaohua.li@intel.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [RFC]cfq-iosched: improve hw_tag detection
Message-ID: <20091026113555.GB10727@kernel.dk>
References: <20091026091624.GA1169@sli10-desk.sh.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20091026091624.GA1169@sli10-desk.sh.intel.com>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 695
Lines: 17

On Mon, Oct 26 2009, Shaohua Li wrote:
> If active queue hasn't enough requests and idle window opens, cfq will not
> dispatch sufficient requests to hardware. In such situation, current code
> will zero hw_tag. But this is because cfq doesn't dispatch enough requests
> instead of hardware queue doesn't work. Don't zero hw_tag in such case.

Thanks, that looks like a good fix. Curious, is this fixing some
regression at your end?

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/