Subject: Re: [PATCH] regulator: keep index within bounds in
 da9034_get_ldo12_voltage()
From: Liam Girdwood <lrg@slimlogic.co.uk>
To: Roel Kluin <roel.kluin@gmail.com>
Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>,
       Andrew Morton <akpm@linux-foundation.org>,
       linux-kernel <linux-kernel@vger.kernel.org>
In-Reply-To: <4AE589E7.7000504@gmail.com>
References: <4AE589E7.7000504@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Date: Mon, 26 Oct 2009 13:45:32 +0000
Message-ID: <1256564732.3530.344.camel@odin>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1100
Lines: 34

On Mon, 2009-10-26 at 12:37 +0100, Roel Kluin wrote:
> If selector equals ARRAY_SIZE(da9034_ldo12_data), that is one too
> large already.
> 
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> ---
>  drivers/regulator/da903x.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/regulator/da903x.c b/drivers/regulator/da903x.c
> index aa224d9..f8c4661 100644
> --- a/drivers/regulator/da903x.c
> +++ b/drivers/regulator/da903x.c
> @@ -331,7 +331,7 @@ static int da9034_get_ldo12_voltage(struct regulator_dev *rdev)
>  static int da9034_list_ldo12_voltage(struct regulator_dev *rdev,
>  				     unsigned selector)
>  {
> -	if (selector > ARRAY_SIZE(da9034_ldo12_data))
> +	if (selector >= ARRAY_SIZE(da9034_ldo12_data))
>  		return -EINVAL;
>  	return da9034_ldo12_data[selector] * 1000;
>  }

Applied.

Thanks

Liam

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/