Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752125AbZJZOls (ORCPT ); Mon, 26 Oct 2009 10:41:48 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751902AbZJZOlr (ORCPT ); Mon, 26 Oct 2009 10:41:47 -0400 Received: from hera.kernel.org ([140.211.167.34]:60938 "EHLO hera.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751676AbZJZOlr (ORCPT ); Mon, 26 Oct 2009 10:41:47 -0400 Message-ID: <4AE5B52A.4050408@kernel.org> Date: Mon, 26 Oct 2009 15:41:46 +0100 From: Tejun Heo User-Agent: Thunderbird 2.0.0.23 (X11/20090817) MIME-Version: 1.0 To: the arch/x86 maintainers , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , athena@fftw.org CC: Linux Kernel Mailing List Subject: [PATCH] x86: fix iommu=nodac parameter handling X-Enigmail-Version: 0.95.7 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1185 Lines: 34 nodac should forbid dac instead of enabling it. Fix it. Signed-off-by: Tejun Heo Cc: Matteo Frigo Cc: stable@kernel.org --- This was posted several months ago in a two patch series. The second one was rejected by Alan and with that the first one got lost too although it's an apparent bug fix. Matteo hit this bug recently and reminded me about this patch. So, regenerated and reposting. Thanks. arch/x86/kernel/pci-dma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/kernel/pci-dma.c b/arch/x86/kernel/pci-dma.c index d20009b..8cf3996 100644 --- a/arch/x86/kernel/pci-dma.c +++ b/arch/x86/kernel/pci-dma.c @@ -216,7 +216,7 @@ static __init int iommu_setup(char *p) if (!strncmp(p, "allowdac", 8)) forbid_dac = 0; if (!strncmp(p, "nodac", 5)) - forbid_dac = -1; + forbid_dac = 1; if (!strncmp(p, "usedac", 6)) { forbid_dac = -1; return 1; -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/