Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752678AbZJZPNC (ORCPT ); Mon, 26 Oct 2009 11:13:02 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752653AbZJZPNB (ORCPT ); Mon, 26 Oct 2009 11:13:01 -0400 Received: from vpn.id2.novell.com ([195.33.99.129]:52255 "EHLO vpn.id2.novell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752655AbZJZPNA convert rfc822-to-8bit (ORCPT ); Mon, 26 Oct 2009 11:13:00 -0400 Message-Id: <4AE5CA8C020000780001BD09@vpn.id2.novell.com> X-Mailer: Novell GroupWise Internet Agent 8.0.1 Date: Mon, 26 Oct 2009 15:13:00 +0000 From: "Jan Beulich" To: "Ingo Molnar" Cc: "Yinghai Lu" , , "Takashi Iwai" , , , Subject: Re: [PATCH] x86: adjust GFP mask handling for coherent allocations References: <4AE06644020000780001B4AD@vpn.id2.novell.com> <20091023114825.GH5886@elte.hu> In-Reply-To: <20091023114825.GH5886@elte.hu> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8BIT Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1038 Lines: 22 >>> Ingo Molnar 23.10.09 13:48 >>> >makes sense (although there were a few odd ends in various ISA sound >driver details so this should go on the .33 not .32), but please >introduce a cleaner construct, like a new DMA_ISA_BIT_MASK() or so. Hmm, I could see DMA_ISA_BIT_MASK only replace DMA_BIT_MASK(24) (but specifically not being conditional upon CONFIG_ISA) without becoming confusing. Consequently this would eliminate the conditional in the .c file. And any attempt to eliminate the conditional another way would just introduce a very similar conditional elsewhere; with this having a single user (and foreseeably not ever a second one) I would think this would just make the code less readable. Or did you have something else in mind that I just don't realize? Jan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/