Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754364AbZJZSD0 (ORCPT ); Mon, 26 Oct 2009 14:03:26 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754296AbZJZSDZ (ORCPT ); Mon, 26 Oct 2009 14:03:25 -0400 Received: from mail-yx0-f187.google.com ([209.85.210.187]:50673 "EHLO mail-yx0-f187.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753085AbZJZSDY convert rfc822-to-8bit (ORCPT ); Mon, 26 Oct 2009 14:03:24 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=Q1ROZKVvD65ZkeyruXIjr6E0MgZ/QcPHFzCtvLvrlPyV/U9IaPIEGdZoX5Kj2qgLE0 tr110BMh4AnsPCqV9v7LJI8u5WriZLXIDcxBgEuGImQMB56IBKSooai4tcyNjTmnanJu O2MoRYMsb2Tl7P4yBEQr8Ppq7Tj30wJo/ZgiA= MIME-Version: 1.0 In-Reply-To: References: <200910202012.43338.czoccolo@gmail.com> Date: Mon, 26 Oct 2009 19:03:28 +0100 Message-ID: <4e5e476b0910261103g3dee483fic19e8713ed52ac3e@mail.gmail.com> Subject: Re: [RFC V2 PATCH 5/5] cfq-iosched: fairness for sync no-idle queues From: Corrado Zoccolo To: Jeff Moyer Cc: Linux-Kernel , Jens Axboe Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1353 Lines: 37 On Mon, Oct 26, 2009 at 4:45 PM, Jeff Moyer wrote: > Corrado Zoccolo writes: > >> +static enum wl_type_t cfqq_type(struct cfq_queue *cfqq) >> +{ >> +     if (!cfq_cfqq_sync(cfqq)) >> +             return ASYNC_WORKLOAD; >> +     if (CFQQ_SEEKY(cfqq) || !cfq_cfqq_idle_window(cfqq)) >> +             return SYNC_NOIDLE_WORKLOAD; >> +     return SYNC_WORKLOAD; >> +} > > The calculation to determine whether or not to idle is now done in at > least 2 places.  Perhaps it's time for a helper function. Maybe that CFQQ_SEEKY(cfqq) test can just be removed, and we just rely on the idle flag set by cfq_update_idle_window (it is already testing seekiness there, but it also considers number of samples). I'll do some testing without it to see if it changes anything. > > There are some other coding style nits, but I'll let Jens comment on > those.  I think the idea looks good.  Once you rebase I'll run some > tests; this is some really good work! > Thanks. Testing on different hardware is always appreciated. Cheers, Corrado > Cheers, > Jeff > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/