Date: Mon, 26 Oct 2009 18:34:16 -0700 (PDT)
Message-Id: <20091026.183416.52095233.davem@davemloft.net>
To: rostedt@goodmis.org
Cc: sam@ravnborg.org, mingo@elte.hu, linux-kernel@vger.kernel.org,
       nico@fluxnic.net, tony.luck@intel.com, sfr@canb.auug.org.au,
       mcgrof@gmail.com, jeff@garzik.org, robert.richter@amd.com,
       dmitry.torokhov@gmail.com, khali@linux-fr.org,
       torvalds@linux-foundation.org
Subject: Re: [RFC] to rebase or not to rebase on linux-next
From: David Miller <davem@davemloft.net>
In-Reply-To: <1256603403.26028.358.camel@gandalf.stny.rr.com>
References: <1256601061.26028.350.camel@gandalf.stny.rr.com>
	<20091026.171539.06989895.davem@davemloft.net>
	<1256603403.26028.358.camel@gandalf.stny.rr.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2052
Lines: 49

From: Steven Rostedt <rostedt@goodmis.org>
Date: Mon, 26 Oct 2009 20:30:03 -0400

> On Mon, 2009-10-26 at 17:15 -0700, David Miller wrote:
> 
>> What you can't do is _PUBLISH_ this anywhere to a tree that people
>> also do development against _UNTIL_ you get those acks and tested-by
>> tags back from people.
>> 
>> Once your acks etc. come in, you can pop all of those pending patches
>> out of your tree, add the ack tags to the commit messages, then
>> reapply them.
>> 
>> Then you can push to your public tree, but no sooner.
>> 
>> It really is that simple.
> 
> But you never answered my question? How long do you let it cook? I don't
> have regular people that test my patches and pass tested by, whatever. I
> get them here and there, sometimes I even a reviewed by.  Most of the
> time I just get silence.

1 day, maybe 2 or even 3 depending upon the type of change and the
travel schedules of core developers.  On the networking lists things
get tested and reviewed quite quickly.

> My testing is mostly done in Ingo's test suite, and that happens after I
> do my push to him. This works best for me.

So you both should keep your trees private until it's all sorted out
and you have the results in hand.

Nobody forces you guys to use public trees just to run Ingo's personal
test suite, you have decided to work that way.  And that is therefore
something you guys can change without effecting other people.

> If I had to publish and let cook on LKML, then I would also need to keep
> better accounting of what I have pushed out and what I have left to do.

The problem isn't that you have to push patches out and only work
with patches, the problem is that you want to use publicly visible
GIT trees to do your testing at all times.

And sorry, that is not how you're supposed to do things.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/