Subject: Re: [PATCH 1/5] dma: create dma_generic_alloc/free_coherent()
From: Alex Williamson <alex.williamson@hp.com>
To: Paul Mundt <lethal@linux-sh.org>
Cc: dwmw2@infradead.org, iommu@lists.linux-foundation.org,
       linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org
In-Reply-To: <20091027005748.GB17085@linux-sh.org>
References: <20091026232401.9646.90540.stgit@nehalem.aw>
	 <20091026232458.9646.36818.stgit@nehalem.aw>
	 <20091027005748.GB17085@linux-sh.org>
Content-Type: text/plain; charset="UTF-8"
Date: Mon, 26 Oct 2009 20:26:39 -0600
Message-ID: <1256610399.19177.3.camel@2710p.home>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1336
Lines: 28

On Tue, 2009-10-27 at 09:57 +0900, Paul Mundt wrote:
> On Mon, Oct 26, 2009 at 05:24:58PM -0600, Alex Williamson wrote:
> > Move dma_generic_alloc_coherent() out of x86 code and create
> > corresponding dma_generic_free_coherent() for symmetry.  These
> > can then be used by IOMMU drivers attempting to implement
> > passthrough mode.
> > 
> Except that dma_generic_alloc_coherent() is only "generic" for platforms
> with consistent DMA. Everyone else will need a cacheflush and potentially
> a remap. It's not even obvious from looking at the consistent DMA
> platforms that they'll be able to use it out of the box due to expecting
> something other than page_address(), which all suggests that this is
> better off remaining an x86-only routine.
> 
> This is also making changes to the DMA-API without any documentation
> updates and without consulting with any other architecture people.

Ok, thanks for the feedback.  Let's forget this patch and I'll see how
amenable David is to doing something within intel-iommu since it only
supports platforms with consistent DMA.  Thanks,

Alex

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/