Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932169AbZJ0IPR (ORCPT ); Tue, 27 Oct 2009 04:15:17 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932110AbZJ0IPQ (ORCPT ); Tue, 27 Oct 2009 04:15:16 -0400 Received: from mail-gx0-f216.google.com ([209.85.217.216]:54078 "EHLO mail-gx0-f216.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932088AbZJ0IPO (ORCPT ); Tue, 27 Oct 2009 04:15:14 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:in-reply-to:references:x-mailer :mime-version:content-type:content-transfer-encoding; b=NsovemoN+7aRTKm1j1M0AC3RxCdqcuVii33PWiXyElB308Hd4r7sBhVrkafNZrO1nn bhhKVwMp70E1FeQEvsE+Q4hR1iUNEAPrzpb9jNinpygA0zd/VJlfDoBflxsYDOgKCPXJ DHggrYW3MZ6HQJQZXgFL6pHPmLv6+6ylceWoU= Date: Tue, 27 Oct 2009 17:14:41 +0900 From: Minchan Kim To: KAMEZAWA Hiroyuki Cc: Minchan Kim , KOSAKI Motohiro , vedran.furac@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, "hugh.dickins@tiscali.co.uk" , "akpm@linux-foundation.org" , rientjes@google.com Subject: Re: [RFC][PATCH] oom_kill: avoid depends on total_vm and use real RSS/swap value for oom_score (Re: Memory overcommit Message-Id: <20091027171441.ca9600ea.minchan.kim@barrios-desktop> In-Reply-To: <20091027165628.acda4540.kamezawa.hiroyu@jp.fujitsu.com> References: <20091014135119.e1baa07f.kamezawa.hiroyu@jp.fujitsu.com> <4ADE3121.6090407@gmail.com> <20091026105509.f08eb6a3.kamezawa.hiroyu@jp.fujitsu.com> <4AE5CB4E.4090504@gmail.com> <20091027122213.f3d582b2.kamezawa.hiroyu@jp.fujitsu.com> <2f11576a0910262310g7aea23c0n9bfc84c900879d45@mail.gmail.com> <20091027153429.b36866c4.minchan.kim@barrios-desktop> <20091027153626.c5a4b5be.kamezawa.hiroyu@jp.fujitsu.com> <28c262360910262355p3cac5c1bla4de9d42ea67fb4e@mail.gmail.com> <20091027164526.da6a23cb.kamezawa.hiroyu@jp.fujitsu.com> <20091027165628.acda4540.kamezawa.hiroyu@jp.fujitsu.com> X-Mailer: Sylpheed 2.6.0 (GTK+ 2.16.1; i486-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1706 Lines: 58 On Tue, 27 Oct 2009 16:56:28 +0900 KAMEZAWA Hiroyuki wrote: > On Tue, 27 Oct 2009 16:45:26 +0900 > KAMEZAWA Hiroyuki wrote: > /* > > * After this unlock we can no longer dereference local variable `mm' > > @@ -92,8 +93,13 @@ unsigned long badness(struct task_struct > > */ > > list_for_each_entry(child, &p->children, sibling) { > > task_lock(child); > > - if (child->mm != mm && child->mm) > > - points += child->mm->total_vm/2 + 1; > > + if (child->mm != mm && child->mm) { > > + unsigned long cpoint; > > + /* At considering child, we don't count swap */ > > + cpoint = get_mm_counter(child->mm, anon_rss) + > > + get_mm_counter(child->mm, file_rss); > > + points += cpoint/2 + 1; > > + } > > task_unlock(child); > > BTW, I'd like to get rid of this code. > > Can't we use other techniques for detecting fork-bomb ? > > This check can't catch following type, anyway. > > fork() > -> fork() > -> fork() > -> fork() > .... > > but I have no good idea. > What is the difference with task-launcher and fork bomb()... > I think it's good as-is. Kernel is hard to know it by effiecient method. It depends on applications. so Doesnt's task-launcher like gnome-session have to control his oom_score? Welcome to any ideas if kernel can do it well. > Thanks, > -Kame > -- Kind regards, Minchan Kim -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/