Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932105AbZJ0TnZ (ORCPT ); Tue, 27 Oct 2009 15:43:25 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753566AbZJ0TnY (ORCPT ); Tue, 27 Oct 2009 15:43:24 -0400 Received: from mail-bw0-f219.google.com ([209.85.218.219]:38922 "EHLO mail-bw0-f219.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753186AbZJ0TnX convert rfc822-to-8bit (ORCPT ); Tue, 27 Oct 2009 15:43:23 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=mDkgk3W13sWhVSxxPfcja/ApgB7gQqp3HulKA9TI75sksV5HnSiSblLFgkHXs7WApq 8bmK4j16ksDsqBljJk55vzzF+TsceL4LlJGAn8FU7yG7jhYhFpYBN5jQhQxKCNSTu+II O7IQ6BS/TVctzDvEllJ2CMMTcrYd29oWNPvcw= MIME-Version: 1.0 In-Reply-To: References: <20090930155557.7dae503b@hskinnemoen-d830> Date: Tue, 27 Oct 2009 21:43:26 +0200 Message-ID: Subject: Re: [PATCH 3/3 v2] at91/atmel-mci: inclusion of sd/mmc driver in at91sam9g45 chip and board From: Andrew Victor To: Nicolas Ferre Cc: linux-mmc@vger.kernel.org, haavard.skinnemoen@atmel.com, akpm@linux-foundation.org, kernel@avr32linux.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 816 Lines: 24 hi Nicolas, > + ? ? ? if (data->slot[0].wp_pin) > + ? ? ? ? ? ? ? at91_set_gpio_input(data->slot[0].wp_pin, 1); > +static struct mci_platform_data __initdata mci0_data = { > + ? ? ? .slot[0] = { > + ? ? ? ? ? ? ? .bus_width ? ? ?= 4, > + ? ? ? ? ? ? ? .detect_pin ? ? = AT91_PIN_PD10, > + ? ? ? ? ? ? ? .wp_pin ? ? ? ? = -1, > + ? ? ? }, Causes at91_set_gpio_input() to be called for pin -1. Which shouldn't be valid. AT91 platforms use 0 to indicate an un-connected GPIO pin, so the assignment of "wp_pin" should probably just be removed. Regards, Andrew Victor -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/