Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932409AbZJ0VVl (ORCPT ); Tue, 27 Oct 2009 17:21:41 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932303AbZJ0VVk (ORCPT ); Tue, 27 Oct 2009 17:21:40 -0400 Received: from mail-bw0-f227.google.com ([209.85.218.227]:36151 "EHLO mail-bw0-f227.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932300AbZJ0VVk (ORCPT ); Tue, 27 Oct 2009 17:21:40 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; b=Au24U+yM3cdFWPkoBP36XdUPlGFO31xH9zxu27VAEV4OjljVlBI8SEqY0qONXM82e8 9TMnFnEYou51deKqFqyyakVpU6Cz8UkueLSCe9zm1iDGItefVGKnoLnaoAtjCfgfgNPh 5gbc0CgP/oCnPzmzLenugpf9QQGM+hkkR41ZQ= Message-ID: <4AE76463.6010404@gmail.com> Date: Tue, 27 Oct 2009 22:21:39 +0100 From: Riccardo Magliocchetti User-Agent: Mozilla-Thunderbird 2.0.0.22 (X11/20090701) MIME-Version: 1.0 To: Jesse Barnes CC: linux-kernel@vger.kernel.org, mjg@redhat.com, eric@anholt.net Subject: Re: no video output after suspend after "drm/i915: force mode set at lid open time" References: <4AE4BBBC.2070809@gmail.com> <20091026090548.2d4e20a9@jbarnes-g45> In-Reply-To: <20091026090548.2d4e20a9@jbarnes-g45> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1933 Lines: 60 Jesse, Jesse Barnes ha scritto: > On Sun, 25 Oct 2009 21:57:32 +0100 > Riccardo Magliocchetti wrote: > >> Hello, >> >> i lost video output, screen stays black, after suspend after commit >> c1c7af60892070e4b82ad63bbfb95ae745056de0 "drm/i915: force mode set at >> lid open time". >> >> I'm attaching my dmesg with 2.6.32-rc5 (actually >> 964fe080d94db82a3268443e9b9ece4c60246414), my bisect log and my >> config. >> >> git bisect response: >> >> c1c7af60892070e4b82ad63bbfb95ae745056de0 is the first bad commit >> commit c1c7af60892070e4b82ad63bbfb95ae745056de0 >> Author: Jesse Barnes >> Date: Thu Sep 10 15:28:03 2009 -0700 >> >> drm/i915: force mode set at lid open time >> [snip] > > I wonder if this is the real problem... This patch introduced an issue > that was fixed by 06891e27a9b5dba5268bb80e41a283f51335afe7 that could > cause a blank screen on lid open or resume, depending on how lid events > were delivered. Should be easy enough to test though, you can remove > the whole > > + if (acpi_lid_open()) > + drm_helper_resume_force_mode(dev); > > block and see if that also helps (in the current tree there's a lock > taken around the force_mode call, you'll need to remove those lines too > for testing). So i've tried separately both this and the patch with the fix for thinkpad (i have a samsung p460aa01 btw) with latest git and they have not fixed the issue. +#if 0 if (acpi_lid_open() && !dev_priv->suspended) { mutex_lock(&dev->mode_config.mutex); drm_helper_resume_force_mode(dev); mutex_unlock(&dev->mode_config.mutex); } +#endif thanks, riccardo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/