Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756876AbZJ0XeE (ORCPT ); Tue, 27 Oct 2009 19:34:04 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756502AbZJ0XeD (ORCPT ); Tue, 27 Oct 2009 19:34:03 -0400 Received: from mga01.intel.com ([192.55.52.88]:8424 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756395AbZJ0XeB (ORCPT ); Tue, 27 Oct 2009 19:34:01 -0400 X-ExtLoop1: 1 Subject: Re: [PATCH 0/5] Candidate fix for increased number of GFP_ATOMIC failures V2 From: reinette chatre To: Mel Gorman Cc: Frans Pop , Jiri Kosina , Sven Geggus , Karol Lewandowski , Tobias Oetiker , "Rafael J. Wysocki" , David Miller , Kalle Valo , David Rientjes , KOSAKI Motohiro , "Abbas, Mohamed" , Jens Axboe , "John W. Linville" , Pekka Enberg , Bartlomiej Zolnierkiewicz , Greg Kroah-Hartman , Stephan von Krawczynski , Kernel Testers List , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" In-Reply-To: <20091027104017.GC8900@csn.ul.ie> References: <1256221356-26049-1-git-send-email-mel@csn.ul.ie> <1256226219.21134.1493.camel@rc-desk> <20091027104017.GC8900@csn.ul.ie> Content-Type: text/plain; charset="UTF-8" Date: Tue, 27 Oct 2009 16:34:05 -0700 Message-Id: <1256686445.21134.10091.camel@rc-desk> Mime-Version: 1.0 X-Mailer: Evolution 2.24.3 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1712 Lines: 38 On Tue, 2009-10-27 at 03:40 -0700, Mel Gorman wrote: > On Thu, Oct 22, 2009 at 08:43:38AM -0700, reinette chatre wrote: > > On Thu, 2009-10-22 at 07:22 -0700, Mel Gorman wrote: > > > [Bug #14141] order 2 page allocation failures in iwlagn > > > Commit 4752c93c30441f98f7ed723001b1a5e3e5619829 introduced GFP_ATOMIC > > > allocations within the wireless driver. This has caused large numbers > > > of failure reports to occur as reported by Frans Pop. Fixing this > > > requires changes to the driver if it wants to use GFP_ATOMIC which > > > is in the hands of Mohamed Abbas and Reinette Chatre. However, > > > it is very likely that it has being compounded by core mm changes > > > that this series is aimed at. > > > > Driver has been changed to allocate paged skb for its receive buffers. > > This reduces amount of memory needed from order-2 to order-1. This work > > is significant and will thus be in 2.6.33. > > > > What do you want to do for -stable in 2.6.31? > I have just posted two patches to stable. The first is to address a bug in which buffer loss occurs when there is an allocation failure and the second is what Frans has been testing that reduces the noise when these allocations fail. They are: iwlwifi: fix potential rx buffer loss­­­­­­­ de0bd50845eb5935ce3d503c5d2f565d6cb9ece1 in linux-2.6 iwlwifi: reduce noise when skb allocation fails ­­­­­­­f82a924cc88a5541df1d4b9d38a0968cd077a051 in linux-2.6 Reinette -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/