Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757086AbZJ1AxY (ORCPT ); Tue, 27 Oct 2009 20:53:24 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757066AbZJ1AxX (ORCPT ); Tue, 27 Oct 2009 20:53:23 -0400 Received: from mail-ew0-f208.google.com ([209.85.219.208]:38840 "EHLO mail-ew0-f208.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757056AbZJ1AxW convert rfc822-to-8bit (ORCPT ); Tue, 27 Oct 2009 20:53:22 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=o3mPCth0+BShabdaqHU2+y4l6ImdiDSl3n2QBqf3xHlOCDXlenCg1O22SpVVbZo3UI oM9JcDg+F8ntgPc7fDb3kdP2Tm5sfe+sG0u/6PlSm7EP56efCpQKWEMt6r3Gz0DeKsL5 C8q0byY3Nx0577Q9a/Ha/6MDt/E06rdqzS2Vc= MIME-Version: 1.0 In-Reply-To: <20091028083548.38f1d80c@hskinnemoen-d830> References: <20090930155557.7dae503b@hskinnemoen-d830> <20091028083548.38f1d80c@hskinnemoen-d830> Date: Tue, 27 Oct 2009 22:53:26 -0200 Message-ID: Subject: Re: [PATCH 3/3 v2] at91/atmel-mci: inclusion of sd/mmc driver in at91sam9g45 chip and board From: =?ISO-8859-1?Q?Thiago_A=2E_Corr=EAa?= To: Haavard Skinnemoen Cc: Andrew Victor , linux-mmc@vger.kernel.org, kernel@avr32linux.org, linux-kernel@vger.kernel.org, Nicolas Ferre , akpm@linux-foundation.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1265 Lines: 32 On Tue, Oct 27, 2009 at 10:35 PM, Haavard Skinnemoen wrote: > Andrew Victor wrote: >> > +static struct mci_platform_data __initdata mci0_data = { >> > + ? ? ? .slot[0] = { >> > + ? ? ? ? ? ? ? .bus_width ? ? ?= 4, >> > + ? ? ? ? ? ? ? .detect_pin ? ? = AT91_PIN_PD10, >> > + ? ? ? ? ? ? ? .wp_pin ? ? ? ? = -1, >> > + ? ? ? }, >> >> Causes at91_set_gpio_input() to be called for pin -1. ?Which shouldn't be valid. >> AT91 platforms use 0 to indicate an un-connected GPIO pin, so the >> assignment of "wp_pin" should probably just be removed. > > The mci driver expects non-existent pins to have a negative value, as > do all other drivers which use gpio_is_valid(). > Then I think it would be best to use GPIO_PIN_NONE. Makes it clear what is expected and avoids confusion on what should be the proper value. I hope I'm not saying non-sense, but even if I am, I guess you can see that I'm advocating against the magic numbers :) Kind Regards, Thiago A. Correa -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/