Date: Wed, 28 Oct 2009 03:43:07 +0000 (GMT)
From: Dave Airlie <airlied@linux.ie>
To: David Miller <davem@davemloft.net>
cc: airlied@gmail.com, andi@firstfloor.org, arnd@arndb.de,
       linux-kernel@vger.kernel.org, dri-devel@lists.sourceforge.net
Subject: Re: is avoiding compat ioctls possible?
In-Reply-To: <20091027.203838.21218679.davem@davemloft.net>
Message-ID: <alpine.DEB.2.00.0910280341331.19088@skynet.skynet.ie>
References: <21d7e9970910271822p3751b2fdnd78e1bc3326b9b0b@mail.gmail.com> <87hbtkjkki.fsf@basil.nowhere.org> <21d7e9970910272005mbb268r7b16493a22ca275a@mail.gmail.com> <20091027.203838.21218679.davem@davemloft.net>
User-Agent: Alpine 2.00 (DEB 1167 2008-08-23)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 851
Lines: 25

> 
> > DrNick on irc suggested just doing:
> > if (is_compat_task()) ptr &= 0x00000000FFFFFFFF;
> > 
> > Is there a one liner I can just do in the actual ioctls instead of
> > adding 20 compat
> > ones?
> 
> Just do the right thing and pass all userland compat pointers
> through the correct compat_*() macros.

I wondered why the other ioctls worked,

(uint32_t __user *)(unsigned long)card_res->fb_id_ptr;

we already opencoded this (probably before it was macroisied or we just 
pasted it), so the radeon one is buggy, I should just go and compat_* all 
of these then and we should be all happy?

Dave.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/