Date: Tue, 27 Oct 2009 22:28:14 -0700 (PDT)
Message-Id: <20091027.222814.137568780.davem@davemloft.net>
To: airlied@linux.ie
Cc: dri-devel@lists.sourceforge.net, andi@firstfloor.org,
       linux-kernel@vger.kernel.org, arnd@arndb.de
Subject: Re: is avoiding compat ioctls possible?
From: David Miller <davem@davemloft.net>
In-Reply-To: <alpine.DEB.2.00.0910280353080.19088@skynet.skynet.ie>
References: <alpine.DEB.2.00.0910280341331.19088@skynet.skynet.ie>
	<20091027.204530.142024242.davem@davemloft.net>
	<alpine.DEB.2.00.0910280353080.19088@skynet.skynet.ie>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1264
Lines: 36

From: Dave Airlie <airlied@linux.ie>
Date: Wed, 28 Oct 2009 03:54:34 +0000 (GMT)

>> 
>> > we already opencoded this (probably before it was macroisied or we just 
>> > pasted it), so the radeon one is buggy, I should just go and compat_* all 
>> > of these then and we should be all happy?
>> 
>> It should be, it's only working because:
>> 
>> 1) A malicious userland hasn't put garbage in the upper bits for
>>    you yet.
>> 
>> 2) Nobody has tested s390 yet :-)
>> 
> 
> So will an inline like this work?
> 
> static inline void *__user convert_user_ptr(uint64_t ioctl_ptr)
> {

Please don't do this.

This is exactly what I feared people would do when is_compat_task()
was added.  is_compat_task() is for situations where there is
otherwise no other way to handle the compat situation properly.

It's not that much work for you to hook up the compat ioctls properly,
and if you are clever you can do it in such a way that you'll get
warnings if someone accidently adds a new ioctl but forgets the
compat bits :-)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/