Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932645AbZJ1H7I (ORCPT ); Wed, 28 Oct 2009 03:59:08 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932628AbZJ1H7H (ORCPT ); Wed, 28 Oct 2009 03:59:07 -0400 Received: from one.firstfloor.org ([213.235.205.2]:47608 "EHLO one.firstfloor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932608AbZJ1H7G (ORCPT ); Wed, 28 Oct 2009 03:59:06 -0400 Date: Wed, 28 Oct 2009 08:59:08 +0100 From: Andi Kleen To: David Miller Cc: airlied@linux.ie, dri-devel@lists.sourceforge.net, andi@firstfloor.org, linux-kernel@vger.kernel.org, arnd@arndb.de Subject: Re: is avoiding compat ioctls possible? Message-ID: <20091028075908.GO7744@basil.fritz.box> References: <20091027.222814.137568780.davem@davemloft.net> <20091027.230450.222178419.davem@davemloft.net> <20091028.005342.60092591.davem@davemloft.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20091028.005342.60092591.davem@davemloft.net> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 506 Lines: 15 > } > - chunk_array_ptr = (uint64_t *)(unsigned long)(cs->chunks); > +#ifdef CONFIG_COMPAT > + if (is_compat_task()) Are the COMPAT ifdefs really needed? The compiler should optimize that away anyways on non compat aware architectures, shouldn't it? -Andi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/