Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753265AbZJ1KYQ (ORCPT ); Wed, 28 Oct 2009 06:24:16 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752719AbZJ1KYP (ORCPT ); Wed, 28 Oct 2009 06:24:15 -0400 Received: from gir.skynet.ie ([193.1.99.77]:60249 "EHLO gir.skynet.ie" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752053AbZJ1KYO (ORCPT ); Wed, 28 Oct 2009 06:24:14 -0400 Date: Wed, 28 Oct 2009 10:24:13 +0000 From: Mel Gorman To: Andrew Morton Cc: stable@kernel.org, linux-kernel@vger.kernel.org, "linux-mm@kvack.org" , Frans Pop , Jiri Kosina , Sven Geggus , Karol Lewandowski , Tobias Oetiker , KOSAKI Motohiro , Pekka Enberg , Rik van Riel , Christoph Lameter , Stephan von Krawczynski , "Kernel Testers List , Mel Gorman "@linux-foundation.org Subject: Re: [PATCH 2/3] page allocator: Do not allow interrupts to use ALLOC_HARDER Message-ID: <20091028102413.GR8900@csn.ul.ie> References: <1256650833-15516-1-git-send-email-mel@csn.ul.ie> <1256650833-15516-3-git-send-email-mel@csn.ul.ie> <20091027130924.fa903f5a.akpm@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <20091027130924.fa903f5a.akpm@linux-foundation.org> User-Agent: Mutt/1.5.17+20080114 (2008-01-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2304 Lines: 58 On Tue, Oct 27, 2009 at 01:09:24PM -0700, Andrew Morton wrote: > On Tue, 27 Oct 2009 13:40:32 +0000 > Mel Gorman wrote: > > > Commit 341ce06f69abfafa31b9468410a13dbd60e2b237 altered watermark logic > > slightly by allowing rt_tasks that are handling an interrupt to set > > ALLOC_HARDER. This patch brings the watermark logic more in line with > > 2.6.30. > > > > [rientjes@google.com: Spotted the problem] > > Signed-off-by: Mel Gorman > > Reviewed-by: Pekka Enberg > > Reviewed-by: Rik van Riel > > Reviewed-by: KOSAKI Motohiro > > --- > > mm/page_alloc.c | 2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > > index dfa4362..7f2aa3e 100644 > > --- a/mm/page_alloc.c > > +++ b/mm/page_alloc.c > > @@ -1769,7 +1769,7 @@ gfp_to_alloc_flags(gfp_t gfp_mask) > > * See also cpuset_zone_allowed() comment in kernel/cpuset.c. > > */ > > alloc_flags &= ~ALLOC_CPUSET; > > - } else if (unlikely(rt_task(p))) > > + } else if (unlikely(rt_task(p)) && !in_interrupt()) > > alloc_flags |= ALLOC_HARDER; > > > > if (likely(!(gfp_mask & __GFP_NOMEMALLOC))) { > > What are the runtime-observeable effects of this change? > A reduction of high-order GFP_ATOMIC allocation failures reported http://www.gossamer-threads.com/lists/linux/kernel/1144153 > The description is a bit waffly-sounding for a -stable backportable > thing, IMO. What reason do the -stable maintainers and users have to > believe that this patch is needed, and an improvement? > Allocation failure reports are occuring against 2.6.31.4 that did not occur in 2.6.30. The bug reporter observes no such allocation failures with this and the previous patch applied. The data is fuzzier than I'd like but both patches do appear to be required. -- Mel Gorman Part-time Phd Student Linux Technology Center University of Limerick IBM Dublin Software Lab -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/